Doc: Clears up trim_char doc #18460
Merged
Doc: Clears up trim_char doc #18460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1535,7 +1535,7 @@ pub trait StrSlice<'a> { | |||
| /// ``` | |||
| fn ends_with(&self, needle: &str) -> bool; | |||
|
|
|||
| /// Returns a string with characters that match `to_trim` removed. | |||
| /// Returns a string with characters that match `to_trim` removed from the left and the right. | |||
There was a problem hiding this comment.
Maybe "beginning and the end" would be better?
There was a problem hiding this comment.
It made the comment 2 lines long :p
I'll update it if it's unclear :)
There was a problem hiding this comment.
Actually it's the terminilogy used in the other trim methods, so it seems more consistent
There was a problem hiding this comment.
@gamazeps OK, sounds good!
|
Historically, 'trim' implies the ends, but it's not bad to be more clear. Thank you! |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Oct 31, 2014
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Nov 3, 2014
bors
added a commit
that referenced
this pull request
Nov 3, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18451