One more import refactoring #203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create an import resolving stage. Currently this involves a copy of the ast, we can probably revisit this once we revisit doing full copies of the ast in general. * Don't repeat work. Once we resolve a import, put it on a hash table and use it next time we are asked for it. This solves a O(n^2) behaviour in degenerated cases. * Once import resolution is done, the target of an import is stored on the import itself.
|
Merged |
oli-obk
added a commit
to oli-obk/rust
that referenced
this pull request
Jul 19, 2017
Allow any offset on integer and ZST pointers
kazcw
pushed a commit
to kazcw/rust
that referenced
this pull request
Oct 23, 2018
…ust-lang#203) * [ci] upgrade to cupid 0.0.5 * [runtime x86] cleanup duplicated code
djtech-dev
pushed a commit
to djtech-dev/rust
that referenced
this pull request
Dec 9, 2021
Add support for debug info.
matthiaskrgr
pushed a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 7, 2023
Support symbol visibility
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am finally happy with this structure. It is efficient (module the unnecessary copying), isolated for next stages and somewhat easy to understand.