Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liblibc: correct Linux ioctl request type #26809

Merged
merged 1 commit into from
Jul 7, 2015
Merged

liblibc: correct Linux ioctl request type #26809

merged 1 commit into from
Jul 7, 2015

Conversation

emberian
Copy link
Member

@emberian emberian commented Jul 5, 2015

No description provided.

@alexcrichton
Copy link
Member

On OSX the manpage says:

int ioctl(int fildes, unsigned long request, ...);

On linux (ubuntu) it says:

int ioctl(int d, int request, ...);

How'd this arise?

@emberian
Copy link
Member Author

emberian commented Jul 6, 2015

That man page (probably ioctl(3p)) is wrong, if you look at the actual /usr/include/sys/ioctl.h or /usr/include/stropts.h headers, or in the kernel source. man 2 ioctl is correct as well.

@emberian
Copy link
Member Author

emberian commented Jul 6, 2015

(It even has the standard "Linux implementation of this interface may differ" disclaimer up top!)

@alexcrichton
Copy link
Member

Fascinating! I'm losing trust in manpages quickly now!

@bors: r+ cea9330bd11379ef56ee0c4f80b44f228660b9e9

@bors
Copy link
Contributor

bors commented Jul 6, 2015

⌛ Testing commit cea9330 with merge 7965f57...

@bors
Copy link
Contributor

bors commented Jul 6, 2015

💔 Test failed - auto-linux-64-nopt-t

@emberian
Copy link
Member Author

emberian commented Jul 6, 2015

@alexcrichton The man pages in section 2 and 3 can usually be trusted, but not section 3p (they're just the POSIX manuals imported directly). But I almost always skip them and go straight to the headers.

@emberian
Copy link
Member Author

emberian commented Jul 6, 2015

@bors: r=alexcrichton rollup

@bors
Copy link
Contributor

bors commented Jul 6, 2015

📌 Commit f2fc920 has been approved by alexcrichton

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 6, 2015
@steveklabnik
Rollup merge of rust-lang#26809 - cmr:libc-ioctl, r=alexcrichton
d6bfd76 
None
@steveklabnik steveklabnik mentioned this pull request Jul 6, 2015
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 6, 2015
@steveklabnik
Rollup merge of rust-lang#26809 - cmr:libc-ioctl, r=alexcrichton
dc7d7d7 
None
@steveklabnik steveklabnik mentioned this pull request Jul 6, 2015
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 7, 2015
@steveklabnik
Rollup merge of rust-lang#26809 - cmr:libc-ioctl, r=alexcrichton
58d0f28 
None
@steveklabnik steveklabnik mentioned this pull request Jul 7, 2015
Merged
bors added a commit that referenced this pull request Jul 7, 2015
@bors
Auto merge of #26844 - steveklabnik:rollup, r=steveklabnik
26f0cd5 
- Successful merges: #26599, #26761, #26807, #26809, #26825, #26827, #26828, #26832, #26834, #26835
- Failed merges: #26796
@bors bors merged commit f2fc920 into rust-lang:master Jul 7, 2015
posborne added a commit to posborne/nix-rust that referenced this pull request Jul 24, 2015
@posborne
ioctl: reintroduce libc ioctl workaround until we can use updated lib…
e9d1e8f 
…libc

This PR fixes the issue upstream rust-lang/rust#26809
but no version 0.2.0 of the crate has been published as of yet.

Signed-off-by: Paul Osborne <osbpau@gmail.com>
posborne added a commit to posborne/nix-rust that referenced this pull request Aug 13, 2015
@posborne
ioctl: reintroduce libc ioctl workaround until we can use updated lib…
1ed5a9b 
…libc

This PR fixes the issue upstream rust-lang/rust#26809
but no version 0.2.0 of the crate has been published as of yet.

Signed-off-by: Paul Osborne <osbpau@gmail.com>
@roblabla roblabla mentioned this pull request Jul 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emberian @alexcrichton @bors @jnicholls