Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of 'just' in trpl/installing-rust.md #29326

Merged
merged 1 commit into from
Oct 27, 2015
Merged

Remove use of 'just' in trpl/installing-rust.md #29326

merged 1 commit into from
Oct 27, 2015

Conversation

varjmes
Copy link

@varjmes varjmes commented Oct 26, 2015

The beginning of the work that needs to be done as part of #28835.

☀️

The beginning of the work that needs to be done as part of #28835.
@varjmes
Copy link
Author

varjmes commented Oct 26, 2015

r? @steveklabnik

@rust-highfive rust-highfive assigned steveklabnik and unassigned brson Oct 26, 2015
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

Looks great! Thanks so much.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Oct 26, 2015

📌 Commit 7447457 has been approved by steveklabnik

@varjmes
Copy link
Author

varjmes commented Oct 26, 2015

Wow that was easy! Thanks @steveklabnik. Will do further "just" removal slowly over time, when I find the time to actually go through the tutorial again like I want to!

@steveklabnik
Copy link
Member

Great 👍

@bors
Copy link
Contributor

bors commented Oct 27, 2015

⌛ Testing commit 7447457 with merge eab5ad5...

bors added a commit that referenced this pull request Oct 27, 2015
The beginning of the work that needs to be done as part of #28835.

:sunny:
@bors
Copy link
Contributor

bors commented Oct 27, 2015

💔 Test failed - auto-win-gnu-64-nopt-t

@steveklabnik
Copy link
Member

@bors: retry

@bors bors merged commit 7447457 into rust-lang:master Oct 27, 2015
@varjmes varjmes deleted the patch-1 branch October 30, 2015 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants