Reorganize rustc_front into rustc::hir. #32570
Conversation
Weed out dependencies on librustc_llvm and librustc. Found while working on #32570. cc @nikomatsakis
|
☔ The latest upstream changes (presumably #32571) made this pull request unmergeable. Please resolve the merge conflicts. |
eddyb
force-pushed
the
tis-but-a-front
branch
2 times, most recently
from
de55fa3
to
1e0df19
Compare
|
☔ The latest upstream changes (presumably #32439) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #31938) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #32666) made this pull request unmergeable. Please resolve the merge conflicts. |
| DEPS_rustc_data_structures := std log serialize | ||
| DEPS_rustc_driver := arena flate getopts graphviz libc rustc rustc_back rustc_borrowck \ | ||
| rustc_typeck rustc_mir rustc_resolve log syntax serialize rustc_llvm \ | ||
| rustc_trans rustc_privacy rustc_lint rustc_front rustc_plugin \ | ||
| rustc_trans rustc_privacy rustc_lint rustc_plugin \ |
|
☔ The latest upstream changes (presumably #32562) made this pull request unmergeable. Please resolve the merge conflicts. |
| if let Some(tcx) = tcx { | ||
| tcx.node_path_str(id) | ||
| } else { | ||
| let path = map.def_path_from_id(id).data; |
There was a problem hiding this comment.
Note that some node-ids do not have a def-path, right? So this might panic?
|
This looks good to me, but I am concerned a bit about the last commit. We probably want to modify |
|
@nikomatsakis It's not used for nodes without a |
|
@bors r+ |
|
📌 Commit 4364907 has been approved by |
|
@bors r=nikomatsakis |
|
📌 Commit 2c44fc4 has been approved by |
|
⌛ Testing commit 2c44fc4 with merge 8be478c... |
|
⛄ The build was interrupted to prioritize another pull request. |
|
⌛ Testing commit 2c44fc4 with merge 84c06a2... |
|
⛄ The build was interrupted to prioritize another pull request. |
|
⌛ Testing commit 2c44fc4 with merge eb8f158... |
|
💔 Test failed - auto-linux-musl-64-opt |
|
@alexcrichton Above failure is legitimate but neither I, locally, nor Travis, actually hit it. |
|
@bors r=nikomatsakis |
|
📌 Commit e8a8dfb has been approved by |
|
⌛ Testing commit e8a8dfb with merge 2f4aef4... |
|
⛄ The build was interrupted to prioritize another pull request. |
|
⌛ Testing commit e8a8dfb with merge 4a49051... |
r? @nikomatsakis Conflicts: src/librustc_save_analysis/lib.rs src/libsyntax/ast_util.rs
|
⛄ The build was interrupted to prioritize another pull request. |
r? @nikomatsakis