Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo lock tidy check #33404

Merged
merged 1 commit into from
May 8, 2016
Merged

Cargo lock tidy check #33404

merged 1 commit into from
May 8, 2016

Conversation

gsquire
Copy link
Contributor

@gsquire gsquire commented May 4, 2016

A rebased PR for #32901

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@gsquire gsquire mentioned this pull request May 4, 2016
Closed
@gsquire
Copy link
Contributor Author

gsquire commented May 4, 2016

r? @alexcrichton

@rust-highfive rust-highfive assigned alexcrichton and unassigned brson May 4, 2016
@alexcrichton
Copy link
Member

@bors: r+ b3de042

Thanks!

@tamird
Copy link
Contributor

tamird commented May 4, 2016

as mentioned in the original PR, it may be worth printing the diff in addition to emitting an opaque failure

Manishearth added a commit to Manishearth/rust that referenced this pull request May 8, 2016
@Manishearth
Rollup merge of rust-lang#33404 - gsquire:cargo-lock, r=alexcrichton
e596211 
Cargo lock tidy check

A rebased PR for rust-lang#32901
@Manishearth Manishearth mentioned this pull request May 8, 2016
Merged
bors added a commit that referenced this pull request May 8, 2016
@bors
Auto merge of #33494 - Manishearth:rollup, r=Manishearth
db94e38 
Rollup of 8 pull requests

- Successful merges: #33369, #33373, #33404, #33406, #33420, #33424, #33426, #33473
- Failed merges:
@bors
Copy link
Contributor

bors commented May 8, 2016

⌛ Testing commit b3de042 with merge 3aeea59...

Manishearth added a commit to Manishearth/rust that referenced this pull request May 8, 2016
@Manishearth
Rollup merge of rust-lang#33404 - gsquire:cargo-lock, r=alexcrichton
0cb966f 
Cargo lock tidy check

A rebased PR for rust-lang#32901
@bors
Copy link
Contributor

bors commented May 8, 2016

⛄ The build was interrupted to prioritize another pull request.

bors added a commit that referenced this pull request May 8, 2016
@bors
Auto merge of #33494 - Manishearth:rollup, r=Manishearth
cae42a4 
Rollup of 8 pull requests

- Successful merges: #33369, #33373, #33404, #33406, #33420, #33424, #33426, #33473
- Failed merges:
@bors bors merged commit b3de042 into rust-lang:master May 8, 2016
@gsquire gsquire deleted the cargo-lock branch May 8, 2016 18:21
@alexcrichton alexcrichton mentioned this pull request May 13, 2016
Closed
@petrochenkov
Copy link
Contributor

This doesn't work on Windows/MSYS2 for some reason, for example in #33794 make tidy run successfully locally, but reported an error on buildbots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gsquire @rust-highfive @alexcrichton @tamird @bors @petrochenkov @brson