bootstrap: stop trashing (DY)LD_LIBRARY_PATH #39950
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Should not commit submodule changes. |
This generated an ugly error with fakeroot before.
ishitatsuyuki
force-pushed
the
stop-trashing-ldpath
branch
from
f5f014f
to
df28569
Compare
|
Fixed. |
| (os.pathsep + env["LD_LIBRARY_PATH"]) \ | ||
| if "LD_LIBRARY_PATH" in env else "" | ||
| env["DYLD_LIBRARY_PATH"] = os.path.join(self.bin_root(), "lib") + \ | ||
| (os.pathsep + env["DYLD_LIBRARY_PATH"]) \ |
There was a problem hiding this comment.
Is os.pathsep the correct separator here? According to the dyld manpage the paths are separated by ':' (and IIRC the same holds for LD_LIBRARY_PATH, too)
There was a problem hiding this comment.
According to docs:
The character conventionally used by the operating system to separate search path components (as in PATH), such as
':'for POSIX or';'for Windows.
This variable is POSIX only anyway, so it works as intended.
|
@bors: r+ |
|
📌 Commit df28569 has been approved by |
… r=alexcrichton bootstrap: stop trashing (DY)LD_LIBRARY_PATH This generated an ugly error with fakeroot before.
… r=alexcrichton bootstrap: stop trashing (DY)LD_LIBRARY_PATH This generated an ugly error with fakeroot before.
Rollup of 28 pull requests - Successful merges: #39859, #39864, #39888, #39903, #39905, #39914, #39945, #39950, #39953, #39961, #39980, #39988, #39993, #39995, #40019, #40020, #40022, #40024, #40025, #40026, #40027, #40031, #40035, #40037, #40038, #40064, #40069, #40086 - Failed merges: #39927, #40008, #40047
This generated an ugly error with fakeroot before.