Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary allocas for indirect function arguments #44573

Merged
merged 1 commit into from
Oct 18, 2017
Merged

Avoid unnecessary allocas for indirect function arguments #44573

merged 1 commit into from
Oct 18, 2017

Commits on Oct 18, 2017

  1. Avoid unnecessary allocas for indirect function arguments 

    The extra alloca was only necessary because it made LLVM implicitly
handle the necessary deref to get to the actual value. The same happens
for indirect arguments that have the byval attribute. But the Rust ABI
does not use the byval attribute and so we need to manually add the
deref operation to the debuginfo.
    @dotdash
    dotdash committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    6bfecd4 View commit details
    Browse the repository at this point in the history