Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of #44215 #44918

Merged
merged 3 commits into from
Oct 2, 2017
Merged

Backport of #44215 #44918

merged 3 commits into from
Oct 2, 2017

Conversation

michaelwoerister
Copy link
Member

Backport of #44215.

r? @alexcrichton
cc @nikomatsakis

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@shepmaster shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 29, 2017
@alexcrichton
Copy link
Member

@bors: r+ p=1

@bors
Copy link
Contributor

bors commented Sep 30, 2017

📌 Commit 99b9ffb has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Sep 30, 2017

⌛ Testing commit 99b9ffb with merge c75d7700742a30bf5559ec000e9a383f69272e49...

@bors
Copy link
Contributor

bors commented Sep 30, 2017

💔 Test failed - status-travis

@michaelwoerister
Copy link
Member Author

Not sure what to make of this error...

@aidanhs
Copy link
Member

aidanhs commented Oct 2, 2017

@bors retry

#38618

@bors
Copy link
Contributor

bors commented Oct 2, 2017

⌛ Testing commit 99b9ffb with merge 07f5ea8...

bors added a commit that referenced this pull request Oct 2, 2017
@bors
Copy link
Contributor

bors commented Oct 2, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 07f5ea8 to beta...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants