Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in libsyntax/parse/lexer/unicode_chars.rs #45231

Closed
wants to merge 1 commit into from
Closed

Fix typo in libsyntax/parse/lexer/unicode_chars.rs #45231

wants to merge 1 commit into from

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Oct 12, 2017

` (U+0060) should be the "grave" accent, not "Greek" accent.

@kennytm
Fix typo in libsyntax/parse/lexer/unicode_chars.rs
b14751c 
` (U+0060) should be the "grave" accent, not "Greek" accent.
@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@petrochenkov
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 12, 2017

📌 Commit b14751c has been approved by petrochenkov

@kennytm kennytm mentioned this pull request Oct 12, 2017
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Oct 12, 2017
@kennytm
Rollup merge of rust-lang#45231 - kennytm:patch-1, r=petrochenkov
45e4c19 
Fix typo in libsyntax/parse/lexer/unicode_chars.rs

`` ` `` (U+0060) should be the "grave" accent, not "Greek" accent.
bors added a commit that referenced this pull request Oct 12, 2017
@bors
Auto merge of #45233 - kennytm:rollup, r=<try>
6f8b325 
[WIP] Rollup of 10 pull requests

- Successful merges: #44989, #45005, #45049, #45105, #45121, #45163, #45166, #45172, #45190, #45231
- Failed merges: #45138
bors added a commit that referenced this pull request Oct 12, 2017
@bors
Auto merge of #45233 - kennytm:rollup, r=kennytm
64ee7d1 
Rollup of 9 pull requests

- Successful merges: #44989, #45005, #45049, #45105, #45121, #45166, #45172, #45190, #45231
- Failed merges: #45138
@kennytm
Copy link
Member Author

kennytm commented Oct 13, 2017

🙄 This has already been merged in #45233:

rust/src/libsyntax/parse/lexer/unicode_chars.rs

Line 147 in 86e5487

('`', "Grave Accent", '\''),

@kennytm kennytm closed this Oct 13, 2017
@kennytm kennytm deleted the patch-1 branch October 13, 2017 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kennytm @rust-highfive @petrochenkov @bors @pnkfelix