Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for Diagnostic::span_suggestion(s) #45486

Merged
merged 1 commit into from
Oct 25, 2017
Merged

Update docs for Diagnostic::span_suggestion(s) #45486

merged 1 commit into from
Oct 25, 2017

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Oct 24, 2017

No description provided.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

oli-obk
oli-obk commented Oct 24, 2017
View reviewed changes
src/librustc_errors/diagnostic.rs
@@ -229,6 +229,7 @@ impl Diagnostic {
/// "try adding parentheses: `(tup.0).1`"
///
/// The message
///
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

markdown doesn't render the bullet points correctly if there's no empty line

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 24, 2017
@kennytm
Copy link
Member

kennytm commented Oct 24, 2017

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 24, 2017

📌 Commit 1ce1d99 has been approved by kennytm

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2017
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Oct 25, 2017
@GuillaumeGomez
Rollup merge of rust-lang#45486 - oli-obk:patch-9, r=kennytm
a95d97a 
Update docs for Diagnostic::span_suggestion(s)
@GuillaumeGomez GuillaumeGomez mentioned this pull request Oct 25, 2017
Merged
bors added a commit that referenced this pull request Oct 25, 2017
@bors
Auto merge of #45513 - GuillaumeGomez:rollup, r=GuillaumeGomez
2f5ae25 
Rollup of 5 pull requests

- Successful merges: #45361, #45461, #45465, #45486, #45502
- Failed merges:
@bors bors merged commit 1ce1d99 into rust-lang:master Oct 25, 2017
@bors
Copy link
Contributor

bors commented Oct 25, 2017

☔ The latest upstream changes (presumably #45513) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk oli-obk deleted the patch-9 branch October 25, 2017 19:12
@oli-obk
Copy link
Contributor Author

oli-obk commented Oct 25, 2017

Bors is drunk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oli-obk @rust-highfive @kennytm @bors @nikomatsakis