Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save-analysis: two fixes + rustfmt #45848

Merged
merged 3 commits into from
Nov 12, 2017
Merged

save-analysis: two fixes + rustfmt #45848

merged 3 commits into from
Nov 12, 2017

Conversation

nrc
Copy link
Member

@nrc nrc commented Nov 7, 2017

Fix two regressions and run rustfmt.

r? @eddyb

This just handles a missing entry, doesn't try to recover, because I couldn't actually find a test case.

cc rust-lang/rls#558
@eddyb
Copy link
Member

eddyb commented Nov 7, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Nov 7, 2017

📌 Commit b98290c has been approved by eddyb

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 10, 2017
@DSpeckhals
Copy link
Contributor

DSpeckhals commented Nov 10, 2017

@nrc Do you think you could update src/tools/rls to rust-lang/rls@015073b in this PR? This is the commit that includes the rls-analysis update.

Edit: Nevermind, I see that you already did in another PR. Thanks anyway!

@bors
Copy link
Contributor

bors commented Nov 12, 2017

⌛ Testing commit b98290c with merge e9f8542...

bors added a commit that referenced this pull request Nov 12, 2017
save-analysis: two fixes + rustfmt

Fix two regressions and run rustfmt.

r? @eddyb
@bors
Copy link
Contributor

bors commented Nov 12, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing e9f8542 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants