Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove left over dead code from suggestion diagnostic refactoring #46039

Merged
merged 1 commit into from
Nov 18, 2017

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Nov 16, 2017

More cleanups after #41876 and #45741

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 16, 2017
@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 17, 2017

hmmm.. I think bors doesn't like me anymore.

r? @petrochenkov

tell me if you don't want to be my default for reviewing diagnostic PRs anymore

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Nov 18, 2017

📌 Commit 47c7e43 has been approved by petrochenkov

@petrochenkov petrochenkov added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2017
@bors
Copy link
Contributor

bors commented Nov 18, 2017

⌛ Testing commit 47c7e43 with merge 6160040...

bors added a commit that referenced this pull request Nov 18, 2017
Remove left over dead code from suggestion diagnostic refactoring

More cleanups after #41876 and #45741
@bors
Copy link
Contributor

bors commented Nov 18, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing 6160040 to master...

@bors bors merged commit 47c7e43 into rust-lang:master Nov 18, 2017
@oli-obk oli-obk deleted the test_suggestions branch December 8, 2017 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants