Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand a couple points in 1.22.0 release notes #46148

Merged
merged 2 commits into from
Nov 21, 2017
Merged

Expand a couple points in 1.22.0 release notes #46148

merged 2 commits into from
Nov 21, 2017

Conversation

SimonSapin
Copy link
Contributor

Let’s not give false hopes about const fn :)

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 21, 2017
@kennytm
Copy link
Member

kennytm commented Nov 21, 2017

It seems none of the standard library const fns are stable to call (not even size_of). I think it is better just remove the whole point...

@kennytm
Copy link
Member

kennytm commented Nov 21, 2017

r? @alexcrichton cc @Aaronepower @bluss @cuviper @durka

@SimonSapin
Copy link
Contributor Author

Right, this is what I meant by false hope. Removing works too, I’ll amend if you prefer that.

@steveklabnik
Copy link
Member

Yes, removing sounds better.

@SimonSapin
Remove 1.23.0 release notes entry on const_fn
13c1cbe 
It doesn’t change anything for stable users in practice. See discussion in rust-lang#46148
@SimonSapin
Copy link
Contributor Author

Done.

@alexcrichton
Copy link
Member

@bors: r+ p=1

@bors
Copy link
Contributor

bors commented Nov 21, 2017

📌 Commit 13c1cbe has been approved by alexcrichton

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2017
@kennytm kennytm mentioned this pull request Nov 21, 2017
Closed
@bors
Copy link
Contributor

bors commented Nov 21, 2017

⌛ Testing commit 13c1cbe with merge 6cfd077ef01bce0bbd953af1ef89ebcf15d8a3c8...

kennytm added a commit to kennytm/rust that referenced this pull request Nov 21, 2017
@kennytm
Rollup merge of rust-lang#46148 - SimonSapin:patch-6, r=alexcrichton
9a69b00 
Expand a couple points in 1.22.0 release notes

Let’s not give false hopes about `const fn` :)
@kennytm kennytm mentioned this pull request Nov 21, 2017
Merged
@kennytm
Copy link
Member

kennytm commented Nov 21, 2017

@bors retry — Prioritizing rollup.

bors added a commit that referenced this pull request Nov 21, 2017
@bors
Auto merge of #46166 - kennytm:rollup, r=kennytm
63739ab 
Rollup of 11 pull requests

- Successful merges: #45987, #46031, #46050, #46052, #46103, #46120, #46134, #46141, #46148, #46155, #46157
- Failed merges:
@bors bors merged commit 13c1cbe into rust-lang:master Nov 21, 2017
@SimonSapin SimonSapin deleted the patch-6 branch November 21, 2017 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SimonSapin @kennytm @steveklabnik @alexcrichton @bors