Add Drop impl for linked_list::DrainFilter #46581
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -1071,6 +1071,15 @@ impl<'a, T, F> Iterator for DrainFilter<'a, T, F> | |||
| } | |||
| } | |||
|
|
|||
| #[unstable(feature = "drain_filter", reason = "recently added", issue = "43244")] | |||
There was a problem hiding this comment.
Trait impls are always stable, so this'll need to be #[stable(feature = "drain_filter_drop", since = "1.25.0")]
kennytm
added
the
S-waiting-on-review
src/liballoc/linked_list.rs
Outdated
| @@ -1071,6 +1071,15 @@ impl<'a, T, F> Iterator for DrainFilter<'a, T, F> | |||
| } | |||
| } | |||
|
|
|||
| #[stable(feature = "drain_filter_drop", since = "1.25.0")] | |||
There was a problem hiding this comment.
@sfackler While trait impls are insta-stable, the type it is implemented for is still unstable, so we can still keep this #[unstable] (see the Debug impl below).
Furthermore, 1.25 doesn't branch off until January, so even if we keep this #[stable] the version should still be 1.24.
There was a problem hiding this comment.
Ah right, thanks for the correction! Sorry about that, @tmccombs - can you switch it back to unstable?
|
@bors r+ |
|
📌 Commit 00acdbd has been approved by |
|
⌛ Testing commit 00acdbd with merge d248834bee8ccda08fe7fadde7e049fd1d934c49... |
This reverts commit 00acdbd.
|
@bors r=sfackler |
|
📌 Commit cdf1d7d has been approved by |
Add Drop impl for linked_list::DrainFilter This is part of #43244. See #43244 (comment)
|
☀️ Test successful - status-appveyor, status-travis |
This is part of #43244. See #43244 (comment)