-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nll part 5 #46733
nll part 5 #46733
Commits on Dec 15, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 86334c7 - Browse repository at this point
Copy the full SHA 86334c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0f0392 - Browse repository at this point
Copy the full SHA a0f0392View commit details -
only propagate ClosureRegionRequirements if non-trivial
Before, we would always have a `Some` ClosureRegionRequirements if we were inferring values for a closure. Now we only do is it has a non-empty set of outlives requirements.
Configuration menu - View commit details
-
Copy full SHA for cd564d2 - Browse repository at this point
Copy the full SHA cd564d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6193c5c - Browse repository at this point
Copy the full SHA 6193c5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for fad3d1d - Browse repository at this point
Copy the full SHA fad3d1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c57468 - Browse repository at this point
Copy the full SHA 1c57468View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebd086b - Browse repository at this point
Copy the full SHA ebd086bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a940b3 - Browse repository at this point
Copy the full SHA 4a940b3View commit details -
move some parts of liveness to happen during type checking
This allows us to re-use the `normalize` method on `TypeCheck`, which is important since normalization may create fresh region variables. This is not an ideal solution, though, since the current representation of "liveness constraints" (a vector of (region, point) pairs) is rather inefficient. Could do somewhat better by converting to indices, but it'd still be less good than the older code. Unclear how important this is.
Configuration menu - View commit details
-
Copy full SHA for 47c1921 - Browse repository at this point
Copy the full SHA 47c1921View commit details -
mild refactors of the control flow (no functional changes)
In the future, `check_type_tests` will also potentially propagate constriants to its caller.
Configuration menu - View commit details
-
Copy full SHA for 02e6525 - Browse repository at this point
Copy the full SHA 02e6525View commit details -
rework region flags: 'static can be erased too
The existing flags did not consider `'static` to be "free". This then fed into what was "erasable" -- but `'static` is most certainly erasable.
Configuration menu - View commit details
-
Copy full SHA for 154cd94 - Browse repository at this point
Copy the full SHA 154cd94View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7cfa23 - Browse repository at this point
Copy the full SHA c7cfa23View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5804637 - Browse repository at this point
Copy the full SHA 5804637View commit details -
propagate type tests from closure to closure creators
Currently, we only propagate type tests that exclude all regions from the type.
Configuration menu - View commit details
-
Copy full SHA for 85e1d47 - Browse repository at this point
Copy the full SHA 85e1d47View commit details -
add a new RegionKind variant: ReClosureBound
This is needed to allow the `ClosureRegionRequirements` to capture types that include regions.
Configuration menu - View commit details
-
Copy full SHA for 3a5842a - Browse repository at this point
Copy the full SHA 3a5842aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fcb13a - Browse repository at this point
Copy the full SHA 3fcb13aView commit details -
impose inputs/ouputs on MIR after the fact
The input/output types found in `UniversalRegions` are not normalized. The old code used to assign them directly into the MIR, which would lead to errors when there was a projection in a argument or return type. This also led to some special cases in the `renumber` code. We now renumber uniformly but then pass the input/output types into the MIR type-checker, which equates them with the types found in MIR. This allows us to normalize at the same time.
Configuration menu - View commit details
-
Copy full SHA for e9824c5 - Browse repository at this point
Copy the full SHA e9824c5View commit details -
add a test regarding relating closure and fn generics
Turns out this works but we had no test targeting it.
Configuration menu - View commit details
-
Copy full SHA for a118afe - Browse repository at this point
Copy the full SHA a118afeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d6bd42 - Browse repository at this point
Copy the full SHA 0d6bd42View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f8ef0c - Browse repository at this point
Copy the full SHA 0f8ef0cView commit details -
stop dumping DefPath into "failed type test" errors
The prior messages were not stable across platforms.
Configuration menu - View commit details
-
Copy full SHA for 4f43c5b - Browse repository at this point
Copy the full SHA 4f43c5bView commit details
Commits on Dec 19, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 03bfb0f - Browse repository at this point
Copy the full SHA 03bfb0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c56c36 - Browse repository at this point
Copy the full SHA 3c56c36View commit details -
remove dead
is_foo_free_region
helpersOnly `is_local_free_region` is used.
Configuration menu - View commit details
-
Copy full SHA for 3d826e5 - Browse repository at this point
Copy the full SHA 3d826e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1816ede - Browse repository at this point
Copy the full SHA 1816edeView commit details