Refactor argument-position impl Trait #46754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramertj
force-pushed
the
refactor-arg-impl
branch
from
aa64cf0
to
e502194
Compare
nikomatsakis
approved these changes
Dec 18, 2017
| @@ -526,20 +535,23 @@ impl<'a> LoweringContext<'a> { | |||
| // Creates a new hir::LifetimeDef for every new lifetime encountered | |||
| // while evaluating `f`. Definitions are created with the parent provided. | |||
| // If no `parent_id` is provided, no definitions will be returned. | |||
There was a problem hiding this comment.
Comment is out of date now I think, should talk also about type parameters
|
@bors r+ |
|
📌 Commit e502194 has been approved by |
kennytm
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 21, 2017
Refactor argument-position impl Trait Fixes #46685, #46470 r? @nikomatsakis cc @chrisvittal
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Dec 21, 2017
Manishearth
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Dec 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46685, #46470
r? @nikomatsakis
cc @chrisvittal