Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incr.comp.: Precompute small hash for filenames to save some work. #46839

Merged
merged 1 commit into from
Dec 22, 2017
Merged

incr.comp.: Precompute small hash for filenames to save some work. #46839

merged 1 commit into from
Dec 22, 2017

Conversation

michaelwoerister
Copy link
Member

For each span we hash the filename of the file it points to. Since filenames can be quite long, especially with absolute paths, this PR pre-computes a hash of the filename and we then only hash the hash.

r? @nikomatsakis

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 19, 2017
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Dec 19, 2017

📌 Commit 0258c6d has been approved by nikomatsakis

@michaelwoerister michaelwoerister added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Dec 21, 2017
@kennytm
Rollup merge of rust-lang#46839 - michaelwoerister:faster-span-hashin…
614e285 
…g-2, r=nikomatsakis

incr.comp.: Precompute small hash for filenames to save some work.

For each span we hash the filename of the file it points to. Since filenames can be quite long, especially with absolute paths, this PR pre-computes a hash of the filename and we then only hash the hash.

r? @nikomatsakis
@kennytm kennytm mentioned this pull request Dec 21, 2017
Merged
bors added a commit that referenced this pull request Dec 21, 2017
@bors
Auto merge of #46922 - kennytm:rollup, r=kennytm
ba27415 
Rollup of 14 pull requests

- Successful merges: #46636, #46780, #46784, #46809, #46814, #46820, #46839, #46847, #46858, #46878, #46884, #46890, #46898, #46918
- Failed merges:
@bors bors merged commit 0258c6d into rust-lang:master Dec 22, 2017
@michaelwoerister michaelwoerister mentioned this pull request Jan 22, 2018
Open
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelwoerister @nikomatsakis @bors @kennytm