Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc: use {U,I}size instead of {U,I}s shorthands. #47170

Merged
merged 2 commits into from
Jan 6, 2018
Merged

rustc: use {U,I}size instead of {U,I}s shorthands. #47170

merged 2 commits into from
Jan 6, 2018

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Jan 4, 2018

Us/Is come from a time when us and is were the literal suffixes that are now usize / isize.

r? @nikomatsakis

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 4, 2018
nikomatsakis
nikomatsakis reviewed Jan 4, 2018
View reviewed changes
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems fine, but it surprises me to see any change in behavior due to it...?

src/test/ui/fat-ptr-cast.stderr
@@ -11,18 +11,24 @@ error[E0606]: casting `&[i32]` as `isize` is invalid
|
21 | a as isize; //~ ERROR casting
| ^^^^^^^^^^
|
= help: cast through a raw pointer first
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I see now

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jan 4, 2018

📌 Commit 210ac01 has been approved by nikomatsakis

kennytm added a commit to kennytm/rust that referenced this pull request Jan 6, 2018
@kennytm
Rollup merge of rust-lang#47170 - eddyb:us-vs-usize, r=nikomatsakis
b63f897 
rustc: use {U,I}size instead of {U,I}s shorthands.

`Us`/`Is` come from a time when `us` and `is` were the literal suffixes that are now `usize` / `isize`.

r? @nikomatsakis
@kennytm kennytm mentioned this pull request Jan 6, 2018
Merged
bors added a commit that referenced this pull request Jan 6, 2018
@bors
Auto merge of #47235 - kennytm:rollup, r=kennytm
6828cf9 
Rollup of 7 pull requests

- Successful merges: #46947, #47170, #47190, #47205, #47217, #47220, #47230
- Failed merges: #47233
@bors bors merged commit 210ac01 into rust-lang:master Jan 6, 2018
@eddyb eddyb deleted the us-vs-usize branch January 6, 2018 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis left review comments

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eddyb @nikomatsakis @bors @kennytm