-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #47492
Rollup of 6 pull requests #47492
Commits on Jan 9, 2018
-
Configuration menu - View commit details
-
Copy full SHA for bdc34fd - Browse repository at this point
Copy the full SHA bdc34fdView commit details
Commits on Jan 12, 2018
-
Configuration menu - View commit details
-
Copy full SHA for f7b4877 - Browse repository at this point
Copy the full SHA f7b4877View commit details -
Configuration menu - View commit details
-
Copy full SHA for f312046 - Browse repository at this point
Copy the full SHA f312046View commit details -
Configuration menu - View commit details
-
Copy full SHA for f18c52b - Browse repository at this point
Copy the full SHA f18c52bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 53d8ec0 - Browse repository at this point
Copy the full SHA 53d8ec0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 43acd23 - Browse repository at this point
Copy the full SHA 43acd23View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50bb6ba - Browse repository at this point
Copy the full SHA 50bb6baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6952199 - Browse repository at this point
Copy the full SHA 6952199View commit details
Commits on Jan 13, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 026c749 - Browse repository at this point
Copy the full SHA 026c749View commit details
Commits on Jan 14, 2018
-
Configuration menu - View commit details
-
Copy full SHA for e2bd0e1 - Browse repository at this point
Copy the full SHA e2bd0e1View commit details
Commits on Jan 15, 2018
-
Don't include bang in macro replacement suggestion
When we suggest the replacement for a macro we include the "!" in the suggested replacement but the span only contains the name of the macro itself. Using that replacement would cause a duplicate "!" in the resulting code. I originally tried to extend the span to be replaced by 1 byte in rust-lang#47424. However, @zackmdavis pointed out that there can be whitespace between the macro name and the bang. Instead, just remove the bang from the suggested replacement. Fixes rust-lang#47418
Configuration menu - View commit details
-
Copy full SHA for ecd47a9 - Browse repository at this point
Copy the full SHA ecd47a9View commit details
Commits on Jan 16, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 3a7e247 - Browse repository at this point
Copy the full SHA 3a7e247View commit details -
Rollup merge of rust-lang#47250 - GuillaumeGomez:test-rustdoc-js, r=M…
…ark-Simulacrum Test rustdoc js Add tests for the rustdoc search. It was heavily required because of all the recent breaking changes that happened while I went through improvements in doc search (add search in/for generic search for example).
Configuration menu - View commit details
-
Copy full SHA for 43634c7 - Browse repository at this point
Copy the full SHA 43634c7View commit details -
Rollup merge of rust-lang#47302 - andjo403:commentfix, r=michaelwoeri…
…ster fix faulty comment after rust-lang#43506 there is no fixed number of request sent.
Configuration menu - View commit details
-
Copy full SHA for 9928bf2 - Browse repository at this point
Copy the full SHA 9928bf2View commit details -
Rollup merge of rust-lang#47387 - Rantanen:linkchecker-error-msg, r=s…
…teveklabnik Report errors instead of panic!() when linkcheck encounters absolute paths The RBE contained some absolute links that failed the link check in rust-lang#46196. Diagnosing these issues was needlessly complicated, thanks to the linkchecker just panicing instead of reporting proper errors. This PR replaces the panic with a proper `*errors = true` + error message handling. The linkchecker itself doesn't have any tests so I intentionally didn't touch anything else than the code that previously did the `panic!()`. A small code quality improvement might be made by binding the `Path::new(base).join(url)` into a variable before the for-loop and using this resolved url in both the for loop and the error message. r? @steveklabnik (If not for any other reason than having r on the rust-lang#46196.)
Configuration menu - View commit details
-
Copy full SHA for 939744d - Browse repository at this point
Copy the full SHA 939744dView commit details -
Rollup merge of rust-lang#47398 - GuillaumeGomez:pulldown-warnings, r…
…=QuietMisdreavus Switch to pulldown as default markdown renderer r? @QuietMisdreavus
Configuration menu - View commit details
-
Copy full SHA for af6bdd2 - Browse repository at this point
Copy the full SHA af6bdd2View commit details -
Rollup merge of rust-lang#47436 - GuillaumeGomez:up-html-diff, r=Quie…
…tMisdreavus Update html-diff crate => fix unicode parsing and invalid paths r? @QuietMisdreavus
Configuration menu - View commit details
-
Copy full SHA for 81ec9d3 - Browse repository at this point
Copy the full SHA 81ec9d3View commit details -
Rollup merge of rust-lang#47444 - etaoins:dont-include-bang-in-macro-…
…suggestion, r=estebank Don't include bang in macro replacement suggestion When we suggest the replacement for a macro we include the "!" in the suggested replacement but the span only contains the name of the macro itself. Using that replacement would cause a duplicate "!" in the resulting code. I originally tried to extend the span to be replaced by 1 byte in rust-lang#47424. However, @zackmdavis pointed out that there can be whitespace between the macro name and the bang. Instead, just remove the bang from the suggested replacement. Fixes rust-lang#47418 r? @estebank
Configuration menu - View commit details
-
Copy full SHA for 83b8946 - Browse repository at this point
Copy the full SHA 83b8946View commit details