Rollup of 14 pull requests #47678
Merged
Rollup of 14 pull requests #47678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kennytm
commented
Jan 23, 2018
•
kennytm
commented
- Successful merges: Check for deadlinks from the summary during book generation #47423, Properly pass down immutability info for thread-locals. #47425, Change the --unpretty flag to -Z unpretty #47440, Fixes sparc64 cabi fixes. #47541, Add regression test for #29723 #47549, Make liballoc_jemalloc work on CloudABI. #47554, Add rustc-args option to test runner #47558, LLVM5: Update DW_OP_plus to DW_OP_plus_uconst #47610, Remove the IGNORED_ATTR_NAMES thread local #47635, Fix spurious warning on empty proc macro crates #47655, Inline some rustc_driver function #47661, Add dynamic-drop test to nll tests also #47662, Fix quoted search #47667, rustdoc: Show when traits are auto traits #47672
- Failed merges:
Previously, any deadlinks from a book's SUMMARY.md wouldn't cause any errors or warnings or similar but mdbook would simply create a page with blank content. This has kept bug rust-lang#47394 hidden. It should have been detected back in the PR when those wrongly named files got added to the book. PR rust-lang#47414 was one component of the solution. This change is a second line of defense for the unstable book and a first line of defense for any other book. We also update mdbook to the most recent version.
Argument up to 16 bytes size is provided in registers. Return value up to 32 bytes size is stored in registers. Fixes: rust-lang#46679
The automated builds for CloudABI in dist-various-2 don't use --disable-jemalloc, even though my original container image did. Instead of setting that flag, let's go the extra mile of making jemalloc work. CloudABI's C library already uses jemalloc and now exposes the API extensions used by us.
-Z unpretty no longer requires -Z unstable-options. Also, I mildly changed the syntax of the flag to match the other -Z flags. All uses of the flag take the form `unpretty=something` where something can either `string` or `string=string` (see the help messages of the CLI).
LLVM <= 4.0 used a non-standard interpretation of `DW_OP_plus`. In the DWARF standard, this adds two items on the expressions stack. LLVM's behavior was more like DWARF's `DW_OP_plus_uconst` -- adding a constant that follows the op. The patch series starting with [D33892] switched to the standard DWARF interpretation, so we need to follow. [D33892]: https://reviews.llvm.org/D33892
It is currently allowed to perform such assignments when not making use of NLL. NLL already does this right, but let's add a test in place to ensure it never regresses.
While attempting to reproduce rust-lang#47086 I noticed the following warning: ```shell > rustc /dev/null --crate-type proc-macro warning: unused variable: `registrar` --> /dev/null:0:1 ``` As there are no macros to register the automatically generated registrar function for the crate has no body. As a result its `registrar` argument is unused triggering the above warning. The warning is confusing and not easily actionable by the developer. It could also be triggered legitimately by e.g. having all of the macros in a crate #[cfg]'ed out. Fix by naming the generated argument `_registrar` inside `mk_registrar()`. This suppresses the unused variable warning.
…hton Check for deadlinks from the summary during book generation Previously, any deadlinks from a book's SUMMARY.md wouldn't cause any errors or warnings or similar but mdbook would simply create a page with blank content. This has kept bug rust-lang#47394 hidden. It should have been detected back in the PR when those wrongly named files got added to the book. PR rust-lang#47414 was one component of the solution. This change is a second line of defense for the unstable book and a first line of defense for any other book. We also update mdbook to the most recent version.
…sakis Properly pass down immutability info for thread-locals. For thread-locals we call into cat_rvalue_node() to create a CMT (Category, Mutability, Type) that always has McDeclared. This is incorrect for thread-locals that don't have the 'mut' keyword; we should use McImmutable there. Extend cat_rvalue_node() to have an additional mutability parameter. Fix up all the callers to make use of that function. Also extend one of the existing unit tests to cover this. Fixes: rust-lang#47053
Change the --unpretty flag to -Z unpretty First PR 😄 ! -Z unpretty no longer requires -Z unstable-options. Also, I mildly changed the syntax of the flag to match the other -Z flags. All uses of the flag take the form `unpretty=something` where something can either `string` or `string=string` (see the help messages of the CLI). Fix rust-lang#47395 r? @nikomatsakis EDIT: apparently rust-highfive doesn't see edits...
Fixes sparc64 cabi fixes. Argument up to 16 bytes size is provided in registers. Return value up to 32 bytes size is stored in registers. Fixes: rust-lang#46679 --- Firefox now (almost) build on sparc. Original rust issue seems to be gone. Note that I'm not rust expert and the fix was suggested in bug.
…omatsakis Add regression test for rust-lang#29723 cc rust-lang#29723 r? @nikomatsakis
…omatsakis Make liballoc_jemalloc work on CloudABI. The automated builds for CloudABI in dist-various-2 don't use --disable-jemalloc, even though my original container image did. Instead of setting that flag, let's go the extra mile of making jemalloc work. CloudABI's C library already uses jemalloc and now exposes the API extensions used by us. This makes the CloudABI dist work out of the box.
Add rustc-args option to test runner r? @nikomatsakis
LLVM5: Update DW_OP_plus to DW_OP_plus_uconst LLVM <= 4.0 used a non-standard interpretation of `DW_OP_plus`. In the DWARF standard, this adds two items on the expressions stack. LLVM's behavior was more like DWARF's `DW_OP_plus_uconst` -- adding a constant that follows the op. The patch series starting with [D33892] switched to the standard DWARF interpretation, so we need to follow. [D33892]: https://reviews.llvm.org/D33892 Fixes rust-lang#47464 r? @eddyb
|
Some changes occurred in HTML/CSS. |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=15 |
|
📌 Commit a5aad7d has been approved by |
kennytm
added
the
S-waiting-on-bors
|
⌛ Testing commit a5aad7d2649dcd90c63453872ec32e5719c3533f with merge 5146773822e2b46c8a672605358b1e890f73875d... |
|
💔 Test failed - status-appveyor |
|
That's strange, logs seem incomplete... |
|
It's just the usual #46903 I believe. |
Remove the IGNORED_ATTR_NAMES thread local
…ty-proc-macro-crate, r=alexcrichton Fix spurious warning on empty proc macro crates While attempting to reproduce rust-lang#47086 I noticed the following warning: ```shell > rustc /dev/null --crate-type proc-macro warning: unused variable: `registrar` --> /dev/null:0:1 ``` As there are no macros to register the automatically generated registrar function for the crate has no body. As a result its `registrar` argument is unused triggering the above warning. The warning is confusing and not easily actionable by the developer. It could also be triggered legitimately by e.g. having all of the macros in a crate #[cfg]'ed out. Fix by naming the generated argument `_registrar` inside `mk_registrar()`. This suppresses the unused variable warning.
…erister Inline some rustc_driver function
…atsakis Add dynamic-drop test to nll tests also r? @nikomatsakis Fixes rust-lang#47585
…=QuietMisdreavus Fix quoted search r? @QuietMisdreavus
…laumeGomez rustdoc: Show when traits are auto traits
|
📌 Commit 9707b31 has been approved by |
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Jan 23, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.