Auto-toolstate management follow-up. #48405

kennytm · 2018-02-21T19:34:59Z

Tracking comment: #45861 (comment)

Fixed Use a proper link for the issue number rust-lang-nursery/rust-toolstate#1, a proper link to the PR will be included.
Fixed Comment on the breaking PR rust-lang-nursery/rust-toolstate#2, a comment will be posted to the PR if the toolstate changed
Toolstate regression will be rejected at the last week of the 6-week cycle (currently entirely date-based).
Implemented https://internals.rust-lang.org/t/the-current-submodule-setup-is-not-tenable/6593, moved doc tests of Nomicon, Reference, Rust-by-Example and The Book to the "tools" job and thus allowed to fail like other external tools.

rust-highfive · 2018-02-21T19:35:03Z

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

kennytm · 2018-02-21T19:36:03Z

(I'll r? someone when it is ready.)

Fix rust-lang-nursery/rust-toolstate#1.

Fix rust-lang-nursery/rust-toolstate#2.

kennytm · 2018-02-22T19:33:45Z

@bors try

bors · 2018-02-22T19:33:56Z

⌛ Trying commit 61259774b2eca687746973bee281d8fd4466144d with merge 89f74e21317085c7fa9e15c87bc308065b9cd358...

kennytm-githubbot · 2018-02-22T21:09:08Z

📣 Toolstate changed by #48405!

Tested on commit 89f74e2.
Direct link to PR: #48405

🎉 book on linux: test-fail → test-pass.
🎉 nomicon on linux: test-fail → test-pass.
🎉 reference on linux: test-fail → test-pass.
🎉 rust-by-example on linux: test-fail → test-pass.

Tested on commit rust-lang/rust@89f74e2. Direct link to PR: <rust-lang/rust#48405> 🎉 book on linux: test-fail → test-pass. 🎉 nomicon on linux: test-fail → test-pass. 🎉 reference on linux: test-fail → test-pass. 🎉 rust-by-example on linux: test-fail → test-pass.

bors · 2018-02-22T21:09:16Z

☀️ Test successful - status-travis
State: approved= try=True

The *.md at the root directory in src/doc are no longer tested, but this should be fine since all files there are deprecated.

kennytm · 2018-02-22T23:56:53Z

r? @Mark-Simulacrum or @alexcrichton

cc @nrc — The comment will look like #48405 (comment).

Also cc @rust-lang/docs. This PR affects the doc tests of the 4 external books (Nomicon, Reference, Rust-by-Example and The Book). After this PR,

These 4 books will only be tested on 64-bit Linux and Windows (MSVC). This should be fine according to @steveklabnik.
If an example from these books failed, the PR will still be allowed to merge. A comment will be posted after merging to announce the breakage, and GitHub will notify the people who maintain that book.

Mark-Simulacrum · 2018-02-23T00:01:39Z

src/ci/docker/x86_64-gnu-tools/checktools.sh

@@ -59,6 +77,11 @@ if [ "$RUST_RELEASE_CHANNEL" = nightly -a -n "${TOOLSTATE_REPO_ACCESS_TOKEN+is_s
        sed -i "1 a\\
 $COMMIT\t$(cat "$TOOLSTATE_FILE")
 " "history/$OS.tsv"
+    # if we are at the last week in the 6-week release cycle, reject any kind of regression.
+    if [ $SIX_WEEK_CYCLE -eq 5 ]; then


I would be a lot more comfortable if this was a 4, since the 5 basically doesn't help much -- last release, we landed breakage to RLS on Monday of the 2nd to last week, which as far as I can tell, this wouldn't have caught. I would like the tools to ideally be green the week of the release, and the week before the release. That seems like a fairly reasonable requirement.

That is 1/3 rd of the release cycle, which seems kind of long. I think what is important is for tool authors to know if their tool is broken going into that final week, since they probably don;t keep track of the release cycle.

I'm fine with leaving it at 5 for a cycle or two and then reevaluating if necessary; my hope is that over time there will be some other solution that we come up with...

What about T-10 days as a compromise? 🤔

Mark-Simulacrum · 2018-02-23T01:16:05Z

r=me pending updates to reviewers, I think

kennytm · 2018-02-25T06:20:02Z

@bors r=Mark-Simulacrum

Since there are no more comments on #48405 (review), I assume the reviewer list is good enough.

bors · 2018-02-25T06:20:02Z

📌 Commit a9f940e has been approved by Mark-Simulacrum

bors · 2018-02-25T06:20:03Z

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

kennytm · 2018-02-28T11:34:52Z

@bors p=1

(Reordered to prevent the rolled-up 48266 from being tested immediately after the rollup 48608. Also this PR should improve the CI time a bit.)

bors · 2018-02-28T14:22:38Z

⌛ Testing commit a9f940e with merge ab1f09e...

…crum Auto-toolstate management follow-up. Tracking comment: #45861 (comment) * Fixed rust-lang-nursery/rust-toolstate#1, a proper link to the PR will be included. * Fixed rust-lang-nursery/rust-toolstate#2, a comment will be posted to the PR if the toolstate changed * Toolstate regression will be rejected at the last week of the 6-week cycle (currently entirely date-based). * Implemented https://internals.rust-lang.org/t/the-current-submodule-setup-is-not-tenable/6593, moved doc tests of Nomicon, Reference, Rust-by-Example and The Book to the "tools" job and thus allowed to fail like other external tools.

bors · 2018-02-28T17:24:41Z

💔 Test failed - status-appveyor

kennytm · 2018-02-28T18:04:17Z

@bors retry p=0

3 hour timeout in check x86_64-pc-windows-msvc.

…Mark-Simulacrum Auto-toolstate management follow-up. Tracking comment: rust-lang#45861 (comment) * Fixed rust-lang-nursery/rust-toolstate#1, a proper link to the PR will be included. * Fixed rust-lang-nursery/rust-toolstate#2, a comment will be posted to the PR if the toolstate changed * Toolstate regression will be rejected at the last week of the 6-week cycle (currently entirely date-based). * Implemented https://internals.rust-lang.org/t/the-current-submodule-setup-is-not-tenable/6593, moved doc tests of Nomicon, Reference, Rust-by-Example and The Book to the "tools" job and thus allowed to fail like other external tools.

kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 21, 2018

rust-highfive assigned aturon Feb 21, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 21, 2018

kennytm removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 21, 2018

kennytm unassigned aturon Feb 21, 2018

kennytm added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Feb 22, 2018

Prepare data for rust-lang/rust#48405.

0b5a146

kennytm added 2 commits February 23, 2018 03:30

Provides direct link to the PR when toolstate is changed.

1acd378

Fix rust-lang-nursery/rust-toolstate#1.

Submit a comment to the PR in additional to pushing a commit.

e181050

Fix rust-lang-nursery/rust-toolstate#2.

kennytm force-pushed the autotoolstate-follow-up branch from 46460a2 to 6125977 Compare February 22, 2018 19:31

kennytm force-pushed the autotoolstate-follow-up branch 2 times, most recently from b0e29d0 to b98561b Compare February 22, 2018 21:38

kennytm added 3 commits February 23, 2018 07:09

Disallow toolstate regression at the last week of the 6-week cycle.

f6e4751

CI: Fixed the incorrect folder region when building codegen dylib.

51238c7

Split test::Docs into one Step for each book.

0d300d4

The *.md at the root directory in src/doc are no longer tested, but this should be fine since all files there are deprecated.

kennytm force-pushed the autotoolstate-follow-up branch 2 times, most recently from 08590c0 to ddc16dd Compare February 22, 2018 23:26

kennytm changed the title ~~[WIP] Auto-toolstate management follow-up.~~ Auto-toolstate management follow-up. Feb 22, 2018

kennytm force-pushed the autotoolstate-follow-up branch from ddc16dd to b0f4e93 Compare February 22, 2018 23:49

kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 22, 2018

rust-highfive assigned Mark-Simulacrum Feb 22, 2018

Mark-Simulacrum reviewed Feb 23, 2018

View reviewed changes

Run the external doc tests in tools job.

a9f940e

kennytm force-pushed the autotoolstate-follow-up branch from b0f4e93 to a9f940e Compare February 23, 2018 16:54

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 28, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 28, 2018

Manishearth mentioned this pull request Mar 1, 2018

Rollup of 9 pull requests #48632

Closed

Manishearth mentioned this pull request Mar 2, 2018

Rollup of 9 pull requests #48652

Merged

bors merged commit a9f940e into rust-lang:master Mar 2, 2018

kennytm deleted the autotoolstate-follow-up branch March 2, 2018 09:06

This was referenced Mar 8, 2018

Comment on the breaking PR rust-lang-nursery/rust-toolstate#2

Closed

Use a proper link for the issue number rust-lang-nursery/rust-toolstate#1

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto-toolstate management follow-up. #48405

Auto-toolstate management follow-up. #48405

kennytm commented Feb 21, 2018 •

edited

Loading

rust-highfive commented Feb 21, 2018

kennytm commented Feb 21, 2018 •

edited

Loading

kennytm commented Feb 22, 2018

bors commented Feb 22, 2018

kennytm-githubbot commented Feb 22, 2018

bors commented Feb 22, 2018

kennytm commented Feb 22, 2018

Mark-Simulacrum Feb 23, 2018

nrc Feb 23, 2018

Mark-Simulacrum Feb 23, 2018

kennytm Feb 23, 2018

Mark-Simulacrum commented Feb 23, 2018

kennytm commented Feb 25, 2018

bors commented Feb 25, 2018

bors commented Feb 25, 2018

kennytm commented Feb 28, 2018 •

edited

Loading

bors commented Feb 28, 2018

bors commented Feb 28, 2018

kennytm commented Feb 28, 2018

Auto-toolstate management follow-up. #48405

Auto-toolstate management follow-up. #48405

Conversation

kennytm commented Feb 21, 2018 • edited Loading

rust-highfive commented Feb 21, 2018

kennytm commented Feb 21, 2018 • edited Loading

kennytm commented Feb 22, 2018

bors commented Feb 22, 2018

kennytm-githubbot commented Feb 22, 2018

bors commented Feb 22, 2018

kennytm commented Feb 22, 2018

Mark-Simulacrum Feb 23, 2018

Choose a reason for hiding this comment

nrc Feb 23, 2018

Choose a reason for hiding this comment

Mark-Simulacrum Feb 23, 2018

Choose a reason for hiding this comment

kennytm Feb 23, 2018

Choose a reason for hiding this comment

Mark-Simulacrum commented Feb 23, 2018

kennytm commented Feb 25, 2018

bors commented Feb 25, 2018

bors commented Feb 25, 2018

kennytm commented Feb 28, 2018 • edited Loading

bors commented Feb 28, 2018

bors commented Feb 28, 2018

kennytm commented Feb 28, 2018

kennytm commented Feb 21, 2018 •

edited

Loading

kennytm commented Feb 21, 2018 •

edited

Loading

kennytm commented Feb 28, 2018 •

edited

Loading