Fix auto trait impl rustdoc ice #48473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
| @@ -3428,7 +3428,9 @@ fn build_deref_target_impls(cx: &DocContext, | |||
| let primitive = match *target { | |||
| ResolvedPath { did, .. } if did.is_local() => continue, | |||
| ResolvedPath { did, .. } => { | |||
| ret.extend(inline::build_impls(cx, did, true)); | |||
| // We set the last parameter to false to avoid looking for auto-impls for traits | |||
| // and therefore avoid an ICE. | |||
There was a problem hiding this comment.
This is only part of the story. The real reason we should pass false here is because auto-traits don't propagate through Deref anyway, so we shouldn't be synthesizing impls for them.
| // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
There was a problem hiding this comment.
Can you add a comment to this test explaining why it's here, or at least referencing the issue?
GuillaumeGomez
force-pushed
the
rustdoc-auto-trait-impl-fix
branch
from
87573d1
to
23dc694
Compare
|
Updated. |
|
@bors r+ rollup |
|
📌 Commit 23dc694 has been approved by |
bors
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Feb 27, 2018
…mpl-fix, r=QuietMisdreavus Fix auto trait impl rustdoc ice Fixes rust-lang#48463. r? @QuietMisdreavus
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Feb 28, 2018
…mpl-fix, r=QuietMisdreavus Fix auto trait impl rustdoc ice Fixes rust-lang#48463. r? @QuietMisdreavus
bors
added a commit
that referenced
this pull request
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48463.
r? @QuietMisdreavus