'label can start expressions #50155
Merged
'label can start expressions #50155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
src/libsyntax/parse/token.rs
Outdated
| @@ -277,6 +277,7 @@ impl Token { | |||
| DotDot | DotDotDot | DotDotEq | // range notation | |||
| Lt | BinOp(Shl) | // associated path | |||
| ModSep | // global path | |||
| Lifetime(..) | // labeled loop | |||
| Pound => true, // expression attributes | |||
| Interpolated(ref nt) => match nt.0 { | |||
| NtIdent(..) | NtExpr(..) | NtBlock(..) | NtPath(..) => true, | |||
There was a problem hiding this comment.
Could you add NtLifetime here as well?
This also needs a test, something like return 'label: loop {} will start parsing with Lifetime(..) being able to start an expression.
petrochenkov
added
S-waiting-on-author
let foo = 'label: loop { break 'label 42; };
is valid Rust code.
est31
force-pushed
the
label_expressions
branch
from
a63f224
to
edee60d
Compare
kennytm
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit edee60d has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Apr 28, 2018
'label can start expressions
```Rust
let foo = 'label: loop { break 'label 42; };
```
is valid Rust code.
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Apr 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is valid Rust code.