Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Backport https://github.com/rust-lang/rust/pull/50748 to beta #50749

Closed

Conversation

steveklabnik
Copy link
Member

This should wait until the backport is approved #50748 (comment)

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!
  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 14, 2018
@alexcrichton
Copy link
Member

@bors: r+

No need for a high p=, this is a low priority backport and can land at any time

@bors
Copy link
Contributor

bors commented May 14, 2018

📌 Commit 1f01721 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2018
@alexcrichton alexcrichton changed the title Backport https://github.com/rust-lang/rust/pull/50748 to beta [beta] Backport https://github.com/rust-lang/rust/pull/50748 to beta May 14, 2018
@pietroalbini
Copy link
Member

Maybe I can merge this in #50741 to avoid having two backport PRs in the queue?

@alexcrichton
Copy link
Member

Sure yeah! Feel free to close this one if you do that

@pietroalbini
Copy link
Member

Merged into #50741.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants