Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc_codegen_llvm: remove some debuginfo cruft. #50949

Merged
merged 2 commits into from
May 24, 2018
Merged

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented May 21, 2018

(The second commit passes tests locally but might not on older LLVM versions)

r? @nikomatsakis

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 21, 2018
@eddyb
Copy link
Member Author

eddyb commented May 21, 2018

Travis CI passed tests and it uses LLVM 3.9 AFAIK, so perhaps the bug isn't in 3.9?
EDIT: do we have LLVM assertions enabled? they might be required to see the problem.
cc @michaelwoerister @alexcrichton

@alexcrichton
Copy link
Member

Sure! May have been in 3.7? If it passes it passes :)

@michaelwoerister
Copy link
Member

This is awesome :)

You can r=me unless you specifically want @nikomatsakis to take a look at it.

@nikomatsakis
Copy link
Contributor

@bors r=mw

@bors
Copy link
Contributor

bors commented May 22, 2018

📌 Commit da579ef has been approved by mw

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2018
@bors
Copy link
Contributor

bors commented May 24, 2018

⌛ Testing commit da579ef with merge 4bd7eeedd5f4c3ed6d4fcd2343f59af8346eeed8...

@bors
Copy link
Contributor

bors commented May 24, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 24, 2018
@rust-highfive

This comment has been minimized.

@kennytm
Copy link
Member

kennytm commented May 24, 2018

@bors retry p=14 #40474

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 24, 2018
@rust-lang rust-lang deleted a comment from rust-highfive May 24, 2018
@bors
Copy link
Contributor

bors commented May 24, 2018

⌛ Testing commit da579ef with merge a76bff8...

bors added a commit that referenced this pull request May 24, 2018
rustc_codegen_llvm: remove some debuginfo cruft.

(The second commit passes tests locally but might not on older LLVM versions)

r? @nikomatsakis
@bors
Copy link
Contributor

bors commented May 24, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: mw
Pushing a76bff8 to master...

@bors bors merged commit da579ef into rust-lang:master May 24, 2018
@eddyb eddyb deleted the debuginfo branch May 24, 2018 12:06
cuviper added a commit to cuviper/rust that referenced this pull request Aug 9, 2018
This hack was removed in rust-lang#50949, but without it I found that building
`std` with full debuginfo would print many LLVM `DW_OP_LLVM_fragment`
errors, then die `LLVM ERROR: Failed to strip malformed debug info`.

It doesn't seem to be a problem for LLVM 6, so we can re-enable the hack
just for older LLVM.

This reverts commit da579ef.
Fixes rust-lang#53204.
r? @eddyb
kennytm added a commit to kennytm/rust that referenced this pull request Aug 13, 2018
rustc_codegen_llvm: Restore the closure env alloca hack for LLVM 5.

This hack was removed in rust-lang#50949, but without it I found that building
`std` with full debuginfo would print many LLVM `DW_OP_LLVM_fragment`
errors, then die `LLVM ERROR: Failed to strip malformed debug info`.

It doesn't seem to be a problem for LLVM 6, so we can re-enable the hack
just for older LLVM.

This reverts commit da579ef.
Fixes rust-lang#53204.
r? @eddyb
kennytm added a commit to kennytm/rust that referenced this pull request Aug 14, 2018
rustc_codegen_llvm: Restore the closure env alloca hack for LLVM 5.

This hack was removed in rust-lang#50949, but without it I found that building
`std` with full debuginfo would print many LLVM `DW_OP_LLVM_fragment`
errors, then die `LLVM ERROR: Failed to strip malformed debug info`.

It doesn't seem to be a problem for LLVM 6, so we can re-enable the hack
just for older LLVM.

This reverts commit da579ef.
Fixes rust-lang#53204.
r? @eddyb
bors pushed a commit that referenced this pull request Aug 25, 2018
This hack was removed in #50949, but without it I found that building
`std` with full debuginfo would print many LLVM `DW_OP_LLVM_fragment`
errors, then die `LLVM ERROR: Failed to strip malformed debug info`.

It doesn't seem to be a problem for LLVM 6, so we can re-enable the hack
just for older LLVM.

This reverts commit da579ef.
Fixes #53204.
r? @eddyb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants