Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dead-code lint: say "constructed" for structs #52332

Commits on Jul 22, 2018

  1. dead-code lint: say "constructed" for structs

    This is a sequel to November 2017's rust-lang#46103 / 1a9dc2e. It had been
    reported (more than once—at least rust-lang#19140, rust-lang#44083, and rust-lang#44565) that the
    "never used" language was confusing for enum variants that were "used"
    as match patterns, so the wording was changed to say never
    "constructed" specifically for enum variants. More recently, the same
    issue was raised for structs (rust-lang#52325). It seems consistent to say
    "constructed" here, too, for the same reasons.
    
    We considered using more specific word "called" for unused functions
    and methods (while we declined to do this in rust-lang#46103, the rationale
    given in the commit message doesn't actually make sense), but it turns
    out that Cargo's test suite expects the "never used" message, and
    maybe we don't care enough even to make a Cargo PR over such a petty
    and subjective wording change.
    
    This resolves rust-lang#52325.
    zackmdavis committed Jul 22, 2018
    Configuration menu
    Copy the full SHA
    6c50ee5 View commit details
    Browse the repository at this point in the history