Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not attempt to recompile codegen backend(s) with --keep-stage #52360

Merged
merged 2 commits into from
Jul 15, 2018
Merged

Do not attempt to recompile codegen backend(s) with --keep-stage #52360

merged 2 commits into from
Jul 15, 2018

Commits on Jul 14, 2018

  1. Do not attempt to recompile codegen backend(s) with --keep-stage 

    Previously we'd attempt to recompile them and that would fail since
we've essentially not built the entire compiler yet, or we're faking
that fact. This commit should make us ignore the codegen backend build
as well.

Unlike the other compile steps, there is no CodegenBackendLink step that
we run here, because that is done later as a part of assembling the
final compiler and as an explicit function call.
    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 14, 2018
    Configuration menu
    Copy the full SHA
    a569c24 View commit details
    Browse the repository at this point in the history

  2. Change keep-stage to only affect the passed stage 

    The best way to build a stage 2 rustc is now probably
  ./x.py build --stage 2 src/rustc # once
  ./x.py build --stage 2 --keep-stage 1 src/rustc
    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 14, 2018
    Configuration menu
    Copy the full SHA
    8eddaba View commit details
    Browse the repository at this point in the history