Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove let x = baz which was obscuring the real error #53129

Merged
merged 1 commit into from
Aug 31, 2018
Merged

remove let x = baz which was obscuring the real error #53129

merged 1 commit into from
Aug 31, 2018

Conversation

nikomatsakis
Copy link
Contributor

fixes #51172

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 6, 2018
@alexcrichton
Copy link
Member

r? @pnkfelix

@pnkfelix
Copy link
Member

pnkfelix commented Aug 7, 2018

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 7, 2018

📌 Commit 2403d91 has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2018
cramertj added a commit to cramertj/rust that referenced this pull request Aug 8, 2018
@cramertj
Rollup merge of rust-lang#53129 - nikomatsakis:issue-51172-tweak-test…
9f38971 
…, r=pnkfelix

remove `let x = baz` which was obscuring the real error

fixes rust-lang#51172
@cramertj cramertj mentioned this pull request Aug 8, 2018
Closed
cramertj added a commit to cramertj/rust that referenced this pull request Aug 8, 2018
@cramertj
Rollup merge of rust-lang#53129 - nikomatsakis:issue-51172-tweak-test…
132b0b3 
…, r=pnkfelix

remove `let x = baz` which was obscuring the real error

fixes rust-lang#51172
This was referenced Aug 8, 2018
Closed
Closed
@cramertj
Copy link
Member

cramertj commented Aug 8, 2018

I'm not sure if there's another commit in the queue which changes the error message here, but this has caused failures in rollups a couple of times: see #53184 (comment) and #53195 (comment).

@kennytm kennytm mentioned this pull request Aug 9, 2018
Merged
@nikomatsakis
Copy link
Contributor Author

I think it is probably because of one of the PRs from @davidtwco or @matthewjasper that change the error messages here.

@kennytm kennytm mentioned this pull request Aug 10, 2018
Closed
@kennytm
Copy link
Member

kennytm commented Aug 11, 2018

@bors rollup-

@bors
Copy link
Contributor

bors commented Aug 13, 2018

⌛ Testing commit 2403d91 with merge 10e06dad64cd7615f37891fbc65c3ab7082e46e8...

@bors
Copy link
Contributor

bors commented Aug 13, 2018

💔 Test failed - status-appveyor

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 13, 2018
@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 13, 2018
@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2018
@pietroalbini
Copy link
Member

Ping from triage @nikomatsakis! It's been a while since we heard from you, will you have time to work on this again?

@nikomatsakis
Copy link
Contributor Author

@bors r=pnkfelix rollup

@bors
Copy link
Contributor

bors commented Aug 27, 2018

📌 Commit f77ad5c has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 27, 2018
@kennytm kennytm mentioned this pull request Aug 28, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Aug 28, 2018
@kennytm
Rollup merge of rust-lang#53129 - nikomatsakis:issue-51172-tweak-test…
2744010 
…, r=pnkfelix

remove `let x = baz` which was obscuring the real error

fixes rust-lang#51172
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Aug 28, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#53129 - nikomatsakis:issue-51172-tweak-test…
40141cc 
…, r=pnkfelix

remove `let x = baz` which was obscuring the real error

fixes rust-lang#51172
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Aug 28, 2018
Closed
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Aug 29, 2018
@pietroalbini
Rollup merge of rust-lang#53129 - nikomatsakis:issue-51172-tweak-test…
94dbcfa 
…, r=pnkfelix

remove `let x = baz` which was obscuring the real error

fixes rust-lang#51172
@pietroalbini pietroalbini mentioned this pull request Aug 29, 2018
Closed
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Aug 29, 2018
@pietroalbini
Rollup merge of rust-lang#53129 - nikomatsakis:issue-51172-tweak-test…
644f8f1 
…, r=pnkfelix

remove `let x = baz` which was obscuring the real error

fixes rust-lang#51172
@pietroalbini pietroalbini mentioned this pull request Aug 29, 2018
Closed
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Aug 30, 2018
@pietroalbini
Rollup merge of rust-lang#53129 - nikomatsakis:issue-51172-tweak-test…
8505270 
…, r=pnkfelix

remove `let x = baz` which was obscuring the real error

fixes rust-lang#51172
@pietroalbini pietroalbini mentioned this pull request Aug 30, 2018
Merged
bors added a commit that referenced this pull request Aug 31, 2018
@bors
Auto merge of #53832 - pietroalbini:rollup, r=pietroalbini
1114ab6 
Rollup of 20 pull requests

Successful merges:

 - #51760 (Add another PartialEq example)
 - #53113 (Add example for Cow)
 - #53129 (remove `let x = baz` which was obscuring the real error)
 - #53389 (document effect of join on memory ordering)
 - #53472 (Use FxHash{Map,Set} instead of the default Hash{Map,Set} everywhere in rustc.)
 - #53476 (Add partialeq implementation for TryFromIntError type)
 - #53513 (Force-inline `shallow_resolve` at its hottest call site.)
 - #53655 (set applicability)
 - #53702 (Fix stabilisation version for macro_vis_matcher.)
 - #53727 (Do not suggest dereferencing in macro)
 - #53732 (save-analysis: Differentiate foreign functions and statics.)
 - #53740 (add llvm-readobj to llvm-tools-preview)
 - #53743 (fix a typo: taget_env -> target_env)
 - #53747 (Rustdoc fixes)
 - #53753 (expand keep-stage --help text)
 - #53756 (Fix typo in comment)
 - #53768 (move file-extension based .gitignore down to src/)
 - #53785 (Fix a comment in src/libcore/slice/mod.rs)
 - #53786 (Replace usages of 'bad_style' with 'nonstandard_style'.)
 - #53806 (Fix UI issues on Implementations on Foreign types)

Failed merges:

r? @ghost
@bors bors merged commit f77ad5c into rust-lang:master Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NLL injects type infer failures in presence of subsequently-masked lifetime errors
8 participants
@nikomatsakis @rust-highfive @alexcrichton @pnkfelix @bors @cramertj @kennytm @pietroalbini