NLL regresses diagnostic for impl-trait/static-return-lifetime-infered.rs #53900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
davidtwco
commented
Sep 2, 2018
src/test/ui/impl-trait/must_outlive_least_region_or_bound.nll.stderr
Outdated
Show resolved
Hide resolved
estebank
reviewed
Sep 3, 2018
src/test/ui/impl-trait/static-return-lifetime-infered.nll.stderr
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
davidtwco
force-pushed
the
issue-53771
branch
from
c30710f
to
df4b196
Compare
pnkfelix
reviewed
Sep 4, 2018
src/librustc_mir/borrow_check/nll/region_infer/error_reporting/mod.rs
Outdated
Show resolved
Hide resolved
nikomatsakis
requested changes
Sep 5, 2018
src/librustc_mir/borrow_check/nll/region_infer/error_reporting/mod.rs
Outdated
Show resolved
Hide resolved
src/librustc_mir/borrow_check/nll/region_infer/error_reporting/mod.rs
Outdated
Show resolved
Hide resolved
src/librustc_mir/borrow_check/nll/region_infer/error_reporting/mod.rs
Outdated
Show resolved
Hide resolved
|
@bors r+ |
|
📌 Commit cd19ce4ad0273ae7dcc0634499fc883609bf95df has been approved by |
bors
added
S-waiting-on-bors
nikomatsakis
approved these changes
Sep 7, 2018
|
☔ The latest upstream changes (presumably #53327) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
davidtwco
force-pushed
the
issue-53771
branch
from
cd19ce4
to
b1e7c63
Compare
|
Rebased. |
| if let Ok(snippet) = infcx.tcx.sess.source_map().span_to_snippet(span) { | ||
| let suggestable_fr_name = match fr_name { | ||
| RegionName::Named(name) => format!("{}", name), | ||
| RegionName::Synthesized(_) => "'_".to_string(), |
There was a problem hiding this comment.
Hmm, I just noticed this; it is not always going to be correct, right?
e.g., in this example
fn foo(x: &[i32], y: &[i32]) -> impl Iterator<Item = i32> {
y.iter().cloned()
}but we should probably just file a follow-up issue.
There was a problem hiding this comment.
We currently get the following for that example:
error[E0621]: explicit lifetime required in the type of `y`
--> test.rs:2:5
|
1 | fn foo(x: &[i32], y: &[i32]) -> impl Iterator<Item = i32> {
| ------ help: add explicit lifetime `'static` to the type of `y`: `&'static [i32]`
2 | y.iter().cloned()
| ^^^^^^^^^^^^^^^^^ lifetime `'static` required
error: unsatisfied lifetime constraints
--> test.rs:2:5
|
1 | fn foo(x: &[i32], y: &[i32]) -> impl Iterator<Item = i32> {
| - - let's call the lifetime of this reference `'1`
| |
| let's call the lifetime of this reference `'2`
2 | y.iter().cloned()
| ^^^^^^^^ requires that `'1` must outlive `'2`
|
@bors r+ |
|
📌 Commit b1e7c635c877c048a1b13087d19eee7cf96ba7f4 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit b1e7c635c877c048a1b13087d19eee7cf96ba7f4 with merge d0d3b809ab3cc7ddeca8caa7f79c56a6ff5b8385... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit b1e7c635c877c048a1b13087d19eee7cf96ba7f4 with merge ce7917c3f41561c8b662faf0b7598a837b825174... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
kennytm
added
S-waiting-on-author
davidtwco
force-pushed
the
issue-53771
branch
from
b1e7c63
to
18c1374
Compare
|
Rebased this. |
|
@bors r+ |
|
📌 Commit 18c1374 has been approved by |
bors
added
S-waiting-on-bors
|
@davidtwco btw, as you have r+ now, you can feel free to do |
bors
added a commit
that referenced
this pull request
Sep 18, 2018
NLL regresses diagnostic for impl-trait/static-return-lifetime-infered.rs Fixes #53771. r? @nikomatsakis cc @pnkfelix @estebank
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Sep 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53771.
r? @nikomatsakis
cc @pnkfelix @estebank