Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize slice::chunks_exact(), chunks_exact_mut(), rchunks(), rchunks_mut(), rchunks_exact(), rchunks_exact_mut() #55178

Merged
merged 2 commits into from
Oct 19, 2018
Merged

Stabilize slice::chunks_exact(), chunks_exact_mut(), rchunks(), rchunks_mut(), rchunks_exact(), rchunks_exact_mut() #55178

merged 2 commits into from
Oct 19, 2018

Conversation

sdroege
Copy link
Contributor

@sdroege sdroege commented Oct 18, 2018 •
edited by kennytm
Loading

Fixes #47115, fixes #55177

@rust-highfive
Copy link
Collaborator

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2018
@sdroege sdroege mentioned this pull request Oct 18, 2018
Closed
1 task
@alexcrichton
Copy link
Member

If you'd like to throw in the rchunks_* style APIs I think that'd be a good idea as well! They're clearly consistent with other APIs we have an the purpose of FCP for the inclusion at all and semantics is taken care of now!

@sdroege
Copy link
Contributor Author

sdroege commented Oct 18, 2018

If you'd like to throw in the rchunks_* style APIs I think that'd be a good idea as well! They're clearly consistent with other APIs we have an the purpose of FCP for the inclusion at all and semantics is taken care of now!

Great, I'll add it once #54580 is in master :)

@bors
Copy link
Contributor

bors commented Oct 18, 2018

☔ The latest upstream changes (presumably #54580) made this pull request unmergeable. Please resolve the merge conflicts.

@sdroege sdroege force-pushed the stabilize-chunks-exact branch 2 times, most recently from a83d82c to cdd7ccd Compare October 18, 2018 15:50
@sdroege sdroege mentioned this pull request Oct 18, 2018
Closed
@sdroege sdroege changed the title Stabilize slice::chunks_exact() and slice::chunks_exact_mut() Stabilize slice::chunks_exact(), chunks_exact_mut(), rchunks(), rchunks_mut(), rchunks_exact(), rchunks_exact_mut() Oct 18, 2018
@sdroege
Copy link
Contributor Author

sdroege commented Oct 18, 2018

Great, I'll add it once #54580 is in master :)

Done, also needed a rebase anyway

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 18, 2018

📌 Commit 52cc6fd has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2018
@kennytm kennytm added the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 19, 2018
@kennytm kennytm mentioned this pull request Oct 19, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Oct 19, 2018
@kennytm
Rollup merge of rust-lang#55178 - sdroege:stabilize-chunks-exact, r=a…
4763c22 
…lexcrichton

Stabilize slice::chunks_exact(), chunks_exact_mut(), rchunks(), rchunks_mut(), rchunks_exact(), rchunks_exact_mut()

Fixes rust-lang#47115, rust-lang#55177
bors added a commit that referenced this pull request Oct 19, 2018
@bors
Auto merge of #55194 - kennytm:rollup, r=kennytm
74ff7dc 
Rollup of 7 pull requests

Successful merges:

 - #54300 (Updated RELEASES.md for 1.30.0)
 - #55013 ([NLL] Propagate bounds from generators)
 - #55071 (Fix ICE and report a human readable error)
 - #55144 (Cleanup resolve)
 - #55166 (Don't warn about parentheses on `match (return)`)
 - #55169 (Add a `copysign` function to f32 and f64)
 - #55178 (Stabilize slice::chunks_exact(), chunks_exact_mut(), rchunks(), rchunks_mut(), rchunks_exact(), rchunks_exact_mut())
@bors bors merged commit 52cc6fd into rust-lang:master Oct 19, 2018
@SimonSapin SimonSapin mentioned this pull request Oct 22, 2018
Closed
@Centril Centril added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Apr 27, 2019
@Centril Centril added this to the 1.31 milestone Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shepmaster shepmaster

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.31
7 participants
@sdroege @rust-highfive @alexcrichton @bors @kennytm @shepmaster @Centril