Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stdsimd submodule #55291

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Update stdsimd submodule #55291

merged 1 commit into from
Oct 25, 2018

Conversation

kazcw
Copy link

@kazcw kazcw commented Oct 23, 2018

Fixes a SSE2 bug. (#55249)

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 23, 2018
@rust-highfive
Copy link
Collaborator

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:00:56] Cloning into '/home/travis/build/rust-lang/rust/src/libcompiler_builtins/libm'...
[00:00:56] Submodule path 'src/libcompiler_builtins/compiler-rt': checked out '7e387f0f90b493ae72930c787c381a80055a7ec9'
[00:00:56] Submodule path 'src/libcompiler_builtins/libm': checked out '96e36ea2620f9fbbaa46a01694a2fa3ef6c2fb7e'
[00:00:56] Submodule path 'src/liblibc': checked out '1844a772b60771d0124a157019f627d60fea4e73'
[00:00:57] error: Server does not allow request for unadvertised object abbebce8b0fcf7fec59c9b1c5e4a5556d5f34161
[00:00:57] Fetched in submodule path 'src/stdsimd', but it did not contain abbebce8b0fcf7fec59c9b1c5e4a5556d5f34161. Direct fetching of that commit failed.
[00:00:58] Cleared directory 'src/dlmalloc'
[00:00:58] Submodule 'src/dlmalloc' (https://github.com/alexcrichton/dlmalloc-rs.git) unregistered for path 'src/dlmalloc'
[00:00:58] Cleared directory 'src/doc/nomicon'
[00:00:58] Submodule 'src/doc/nomicon' (https://github.com/rust-lang-nursery/nomicon.git) unregistered for path 'src/doc/nomicon'
---
[00:00:58] Submodule path 'src/libcompiler_builtins': checked out '0703bfa72524e01e414477657ca9b64794c5c1c3'
[00:00:58] Submodule path 'src/libcompiler_builtins/compiler-rt': checked out '7e387f0f90b493ae72930c787c381a80055a7ec9'
[00:00:58] Submodule path 'src/libcompiler_builtins/libm': checked out '96e36ea2620f9fbbaa46a01694a2fa3ef6c2fb7e'
[00:00:58] Submodule path 'src/liblibc': checked out '1844a772b60771d0124a157019f627d60fea4e73'
[00:00:59] error: Server does not allow request for unadvertised object abbebce8b0fcf7fec59c9b1c5e4a5556d5f34161
[00:00:59] Fetched in submodule path 'src/stdsimd', but it did not contain abbebce8b0fcf7fec59c9b1c5e4a5556d5f34161. Direct fetching of that commit failed.
[00:01:01] Cleared directory 'src/dlmalloc'
[00:01:01] Submodule 'src/dlmalloc' (https://github.com/alexcrichton/dlmalloc-rs.git) unregistered for path 'src/dlmalloc'
[00:01:01] Cleared directory 'src/doc/nomicon'
[00:01:01] Submodule 'src/doc/nomicon' (https://github.com/rust-lang-nursery/nomicon.git) unregistered for path 'src/doc/nomicon'
---
[00:01:02] Submodule path 'src/libcompiler_builtins': checked out '0703bfa72524e01e414477657ca9b64794c5c1c3'
[00:01:02] Submodule path 'src/libcompiler_builtins/compiler-rt': checked out '7e387f0f90b493ae72930c787c381a80055a7ec9'
[00:01:02] Submodule path 'src/libcompiler_builtins/libm': checked out '96e36ea2620f9fbbaa46a01694a2fa3ef6c2fb7e'
[00:01:02] Submodule path 'src/liblibc': checked out '1844a772b60771d0124a157019f627d60fea4e73'
[00:01:03] error: Server does not allow request for unadvertised object abbebce8b0fcf7fec59c9b1c5e4a5556d5f34161
[00:01:03] Fetched in submodule path 'src/stdsimd', but it did not contain abbebce8b0fcf7fec59c9b1c5e4a5556d5f34161. Direct fetching of that commit failed.
[00:01:06] Cleared directory 'src/dlmalloc'
[00:01:06] Submodule 'src/dlmalloc' (https://github.com/alexcrichton/dlmalloc-rs.git) unregistered for path 'src/dlmalloc'
[00:01:06] Cleared directory 'src/doc/nomicon'
[00:01:06] Submodule 'src/doc/nomicon' (https://github.com/rust-lang-nursery/nomicon.git) unregistered for path 'src/doc/nomicon'
---
[00:01:07] Submodule path 'src/libcompiler_builtins': checked out '0703bfa72524e01e414477657ca9b64794c5c1c3'
[00:01:07] Submodule path 'src/libcompiler_builtins/compiler-rt': checked out '7e387f0f90b493ae72930c787c381a80055a7ec9'
[00:01:07] Submodule path 'src/libcompiler_builtins/libm': checked out '96e36ea2620f9fbbaa46a01694a2fa3ef6c2fb7e'
[00:01:07] Submodule path 'src/liblibc': checked out '1844a772b60771d0124a157019f627d60fea4e73'
[00:01:08] error: Server does not allow request for unadvertised object abbebce8b0fcf7fec59c9b1c5e4a5556d5f34161
[00:01:08] Fetched in submodule path 'src/stdsimd', but it did not contain abbebce8b0fcf7fec59c9b1c5e4a5556d5f34161. Direct fetching of that commit failed.
[00:01:12] Cleared directory 'src/dlmalloc'
[00:01:12] Submodule 'src/dlmalloc' (https://github.com/alexcrichton/dlmalloc-rs.git) unregistered for path 'src/dlmalloc'
[00:01:12] Cleared directory 'src/doc/nomicon'
[00:01:12] Submodule 'src/doc/nomicon' (https://github.com/rust-lang-nursery/nomicon.git) unregistered for path 'src/doc/nomicon'
---
[00:01:12] Submodule path 'src/libcompiler_builtins': checked out '0703bfa72524e01e414477657ca9b64794c5c1c3'
[00:01:13] Submodule path 'src/libcompiler_builtins/compiler-rt': checked out '7e387f0f90b493ae72930c787c381a80055a7ec9'
[00:01:13] Submodule path 'src/libcompiler_builtins/libm': checked out '96e36ea2620f9fbbaa46a01694a2fa3ef6c2fb7e'
[00:01:13] Submodule path 'src/liblibc': checked out '1844a772b60771d0124a157019f627d60fea4e73'
[00:01:14] error: Server does not allow request for unadvertised object abbebce8b0fcf7fec59c9b1c5e4a5556d5f34161
[00:01:14] Fetched in submodule path 'src/stdsimd', but it did not contain abbebce8b0fcf7fec59c9b1c5e4a5556d5f34161. Direct fetching of that commit failed.
travis_time:end:02b5e698:start=1540313024330827966,finish=1540313098370468254,duration=74039640288

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 1.
travis_time:start:0343dc56
---
travis_time:end:08e5daa0:start=1540313098646270144,finish=1540313098651040796,duration=4770652
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:011206c6
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:2538f4fc
travis_time:start:2538f4fc
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:005d622a
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Fixes a SSE2 bug.
@kazcw
Copy link
Author

kazcw commented Oct 23, 2018

Oops, original commit tried to update the submodule to the rev from my PR instead of the rev as merged

@nikomatsakis
Copy link
Contributor

@bors r+ rollup

@kazcw thanks!

@bors
Copy link
Contributor

bors commented Oct 23, 2018

📌 Commit 3d9231c has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2018
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Oct 23, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Oct 25, 2018
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Oct 25, 2018
bors added a commit that referenced this pull request Oct 25, 2018
Rollup of 22 pull requests

Successful merges:

 - #53507 (Add doc for impl From for Waker)
 - #53931 (Gradually expanding libstd's keyword documentation)
 - #54965 (update tcp stream documentation)
 - #54977 (Accept `Option<Box<$t:ty>>` in macro argument)
 - #55138 (in which unused-parens suggestions heed what the user actually wrote)
 - #55173 (Suggest appropriate syntax on missing lifetime specifier in return type)
 - #55200 (Documents `From` implementations for `Stdio`)
 - #55245 (submodules: update clippy from 5afdf8b to b1d0343)
 - #55247 (Clarified code example in char primitive doc)
 - #55251 (Fix a typo in the documentation of RangeInclusive)
 - #55253 (only issue "variant of the expected type" suggestion for enums)
 - #55254 (Correct trailing ellipsis in name_from_pat)
 - #55269 (fix typos in various places)
 - #55282 (Remove redundant clone)
 - #55285 (Do some copy editing on the release notes)
 - #55291 (Update stdsimd submodule)
 - #55296 (Set RUST_BACKTRACE=0 for rustdoc-ui/failed-doctest-output.rs)
 - #55306 (Regression test for #54478.)
 - #55328 (Fix doc for new copysign functions)
 - #55340 (Operands no longer appear in places)
 - #55345 (Remove is_null)
 - #55348 (Update RELEASES.md after destabilization of non_modrs_mods)

Failed merges:

r? @ghost
@bors bors merged commit 3d9231c into rust-lang:master Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants