Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Value visitors for miri #55549

Merged
merged 21 commits into from
Nov 7, 2018
Merged

Value visitors for miri #55549

merged 21 commits into from
Nov 7, 2018

Commits on Nov 5, 2018

  1. generalize the traversal part of validation to a ValueVisitor

    @RalfJung
    RalfJung committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    5b5e076 View commit details
    Browse the repository at this point in the history

  2. reduce the amount of traversal/projection code that the visitor has t… 

    …o implement itself
    @RalfJung
    RalfJung committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    7d7bd9b View commit details
    Browse the repository at this point in the history

  3. also allow visiting places and mplaces

    @RalfJung
    RalfJung committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    c8e471f View commit details
    Browse the repository at this point in the history

  4. fix for pre-NLL rustc

    @RalfJung
    RalfJung committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    fdc3a3e View commit details
    Browse the repository at this point in the history

  5. add visit() hook to the trait

    @RalfJung
    RalfJung committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    33770ab View commit details
    Browse the repository at this point in the history

  6. provide some default implementations

    @RalfJung
    RalfJung committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    b0f1b1a View commit details
    Browse the repository at this point in the history

  7. let the Value handle enum projections, so the visitor does not have t… 

    …o care
    @RalfJung
    RalfJung committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    6d24b37 View commit details
    Browse the repository at this point in the history

  8. fix validation error on non-integer enum discriminants

    @RalfJung
    RalfJung committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    fa01e04 View commit details
    Browse the repository at this point in the history

  9. Also test for undef in enum discriminant 

    The error message is sub-par, but fixing that requries moving ScalarMaybeUndef
to librustc which would conflict badly with another PR that is in flight.
    @RalfJung
    RalfJung committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    77c2834 View commit details
    Browse the repository at this point in the history

  10. converting a VisitorValue to a MemPlace must not mutate anything

    @RalfJung
    RalfJung committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    aea61e3 View commit details
    Browse the repository at this point in the history

  11. use more traditional walk_array/visit_array instead of the handle_arr… 

    …ay hook
    @RalfJung
    RalfJung committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    98295e9 View commit details
    Browse the repository at this point in the history

  12. finally this actually looks like a visitor

    @RalfJung
    RalfJung committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    b096f08 View commit details
    Browse the repository at this point in the history

  13. all values can convert to operators

    @RalfJung
    RalfJung committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    c267721 View commit details
    Browse the repository at this point in the history

  14. the visitor can already load the value for visit_primitive

    @RalfJung
    RalfJung committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    996a425 View commit details
    Browse the repository at this point in the history

  15. visit_aggregate with an iterator; fix some comment typos

    @RalfJung
    RalfJung committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    91cad39 View commit details
    Browse the repository at this point in the history

  16. FIXME

    @RalfJung
    RalfJung committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    0d596f2 View commit details
    Browse the repository at this point in the history

  17. machine hooks for ptr (de)ref also need layout, and then they do not … 

    …need the size
    @RalfJung
    RalfJung committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    7565b5a View commit details
    Browse the repository at this point in the history

  18. make ValueVisitor mut-polymorphic

    @RalfJung
    RalfJung committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    8730410 View commit details
    Browse the repository at this point in the history

  19. proide ptr_wrapping_offset on Scalars

    @RalfJung
    RalfJung committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    0529dc8 View commit details
    Browse the repository at this point in the history

  20. walk_value: more tracing

    @RalfJung
    RalfJung committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    a0074ca View commit details
    Browse the repository at this point in the history

  21. add method to obtain the ptr offset of a Scalar

    @RalfJung
    RalfJung committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    7b7c6ce View commit details
    Browse the repository at this point in the history