Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cg_llvm::rpath and parts of cg_llvm::back::link to rustc_codegen_utils #55725

Closed
wants to merge 2 commits into from

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Nov 6, 2018

No description provided.

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 6, 2018
@bjorn3 bjorn3 changed the title Move cg_llvm::rpath to rustc_codegen_utils Move cg_llvm::rpath and parts of cg_llvm::back::link to rustc_codegen_utils Nov 7, 2018
@eddyb
Copy link
Member

eddyb commented Nov 7, 2018

Let's please not add more things to rustc_codegen_utils.
Also this looks similar to a subset of #55627, which I'm rebasing right now.
I'd rather land #55627 ASAP and avoid it bitrotting.

@bjorn3
Copy link
Member Author

bjorn3 commented Nov 7, 2018

Sure

@bjorn3 bjorn3 closed this Nov 7, 2018
@bjorn3 bjorn3 deleted the move_some_things_to_cg_utils branch November 7, 2018 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants