Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ICE in const slice patterns #55922

Merged
merged 4 commits into from
Dec 5, 2018
Merged

Fix ICE in const slice patterns #55922

merged 4 commits into from
Dec 5, 2018

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Nov 13, 2018 •
edited
Loading

fixes #55911

based on #55915

New commits start at eabc1551e0d0953f1951020afb5919ab4c129cf5

@rust-highfive
Copy link
Collaborator

r? @zackmdavis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 13, 2018
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@oli-obk oli-obk added the S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. label Nov 19, 2018
@bors

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@oli-obk oli-obk removed the S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. label Nov 29, 2018
@oli-obk
Copy link
Contributor Author

oli-obk commented Dec 3, 2018

cc @zackmdavis this could use a review in the next days so it makes the beta branchoff

@zackmdavis
Copy link
Member

zackmdavis commented Dec 3, 2018 •
edited
Loading

@oli-obk oh, thanks for the reminder; I hereby pledge to review this tonight (UTC -8, so like 12ish hours from now)

@zackmdavis
Copy link
Member

(I have some lingering uncertainty about exactly how deep of an understanding reviewers are morally obligated to exercise before r+ing; I don't personally have a lot of context on MIR/HAIR yet. But as code that looks sane, from a core contributor, that's fixing an ICE (rather than architecting new functionality), that passes Travis, I'm pretty sure this is fine.)

@bors r+

@bors
Copy link
Contributor

bors commented Dec 4, 2018

📌 Commit 8f9a093 has been approved by zackmdavis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2018
@bors
Copy link
Contributor

bors commented Dec 5, 2018

⌛ Testing commit 8f9a093 with merge 21cb46a...

bors added a commit that referenced this pull request Dec 5, 2018
@bors
Auto merge of #55922 - oli-obk:slice_pat_ice, r=zackmdavis
21cb46a 
Fix ICE in `const` slice patterns

fixes #55911

based on #55915

New commits start at eabc1551e0d0953f1951020afb5919ab4c129cf5
@bors
Copy link
Contributor

bors commented Dec 5, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: zackmdavis
Pushing 21cb46a to master...

@bors bors merged commit 8f9a093 into rust-lang:master Dec 5, 2018
@bors bors mentioned this pull request Dec 5, 2018
Merged
@oli-obk oli-obk deleted the slice_pat_ice branch June 15, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zackmdavis zackmdavis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE: Slice pattern matching with constant slice and slice literal
4 participants
@oli-obk @rust-highfive @bors @zackmdavis