Incorporate dyn into more comments and docs.
#56101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
frewsxcv
force-pushed
the
frewsxcv-dyn
branch
from
92d256c
to
033cbfe
Compare
frewsxcv
added
the
A-docs
|
☔ The latest upstream changes (presumably #56118) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I'm not sure to see the why of this PR. It works without |
|
|
r=me after the conflict has been fixed |
|
@bors r=steveklabnik rollup |
|
📌 Commit ebb1a48 has been approved by |
bors
added
S-waiting-on-bors
RalfJung
reviewed
Nov 23, 2018
| @@ -8,7 +8,8 @@ | |||
| // option. This file may not be copied, modified, or distributed | |||
| // except according to those terms. | |||
|
|
|||
| // Ensure that both `Box<Error + Send + Sync>` and `Box<Error>` can be obtained from `String`. | |||
| // Ensure that both `Box<dyn Error + Send + Sync>` and `Box<dyn Error>` can be | |||
| // obtained from `String`. | |||
There was a problem hiding this comment.
Shouldn't the types in the code below be consistent with the ones in the comment here?
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Nov 25, 2018
Incorporate `dyn` into more comments and docs. r? @rust-lang/docs
bors
added a commit
that referenced
this pull request
Nov 25, 2018
Rollup of 14 pull requests Successful merges: - #56024 (Don't auto-inline const functions) - #56045 (Check arg/ret sizedness at ExprKind::Path) - #56072 (Stabilize macro_literal_matcher) - #56075 (Encode a custom "producers" section in wasm files) - #56100 (generator fields are not necessarily initialized) - #56101 (Incorporate `dyn` into more comments and docs.) - #56144 (Fix BTreeSet and BTreeMap gdb pretty-printers) - #56151 (Move a flaky process test out of libstd) - #56170 (Fix self profiler ICE on Windows) - #56176 (Panic setup msg) - #56204 (Suggest correct enum variant on typo) - #56207 (Stabilize the int_to_from_bytes feature) - #56210 (read_c_str should call the AllocationExtra hooks) - #56211 ([master] Forward-ports from beta) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @rust-lang/docs