Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #56905 #56906

Merged
merged 5 commits into from
Jan 12, 2019
Merged

Issue #56905 #56906

merged 5 commits into from
Jan 12, 2019

Commits on Jan 9, 2019

  1. Issue 56905 

    Adding a map to TypeckTables to get the list of all the Upvars
given a closureID. This is help us get rid of the recurring
pattern in the codebase of iterating over the free vars
using with_freevars.
    @blitzerr
    blitzerr committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    47db51e View commit details
    Browse the repository at this point in the history

  2. Creating the vector using with_capacity to avoid re-allocation later … 

    …on (#56905)
    @blitzerr
    blitzerr committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    410b529 View commit details
    Browse the repository at this point in the history

  3. Some more refactoring. 

    Change the key of UpvarListMap from DefId to ast::NodeId
    @blitzerr
    blitzerr committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    7853b78 View commit details
    Browse the repository at this point in the history

  4. [Cleanup] This is the first in the series of removals of with_freevar… 

    …s usage.

Currently, there are many places in rustc, where we use
with_freevars to iterate over freevars of a closure. The
problem with this is the argument to with_freevars is a
NodeId and this will get in the way of our eventual goal
of solving for issue (#53488), sub-issue (#56905)
    @blitzerr
    blitzerr committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    15d8e8f View commit details
    Browse the repository at this point in the history

  5. addressing Niko's comments

    @blitzerr
    blitzerr committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    69e4918 View commit details
    Browse the repository at this point in the history