Const-stabilize `const_int_ops` + `const_ip` #57234

Centril · 2018-12-31T15:44:06Z

r? @oli-obk

Note for relnotes: This PR includes #57105.

I've added T-lang since this affects intrinsics and the operational semantics of Rust's const fn fragment.

Stable APIs proposed for constification

const_int_ops:
- count_ones
- count_zeros
- leading_zeros
- trailing_zeros
- swap_bytes
- from_be
- from_le
- to_be
- to_le
const_ip
- Ipv4Addr::new

Unstable APIs constified

const_int_conversion:
- reverse_bits

Centril · 2018-12-31T15:44:36Z

@rfcbot merge

rfcbot · 2018-12-31T15:44:37Z

src/librustc_mir/transform/qualify_min_const_fn.rs

rfcbot · 2019-01-08T22:25:40Z

🔔 This is now entering its final comment period, as per the review above. 🔔

oli-obk · 2019-01-11T11:58:07Z

@bors r+

bors · 2019-01-11T11:58:08Z

📌 Commit 14be8a7 has been approved by oli-obk

@oli-obk

…li-obk Const-stabilize `const_int_ops` + `const_ip` r? @oli-obk I've added T-lang since this affects intrinsics and the operational semantics of Rust's `const fn` fragment. This PR depends on rust-lang#57105 but the FCP intent does not. ## Stable APIs proposed for constification + `const_int_ops`: + `count_ones` + `count_zeros` + `leading_zeros` + `trailing_zeros` + `swap_bytes` + `from_be` + `from_le` + `to_be` + `to_le` + `const_ip` + `Ipv4Addr::new` ## Unstable APIs constified + `const_int_conversion`: + `reverse_bits`

@oli-obk

…li-obk Const-stabilize `const_int_ops` + `const_ip` r? @oli-obk I've added T-lang since this affects intrinsics and the operational semantics of Rust's `const fn` fragment. This PR depends on rust-lang#57105 but the FCP intent does not. ## Stable APIs proposed for constification + `const_int_ops`: + `count_ones` + `count_zeros` + `leading_zeros` + `trailing_zeros` + `swap_bytes` + `from_be` + `from_le` + `to_be` + `to_le` + `const_ip` + `Ipv4Addr::new` ## Unstable APIs constified + `const_int_conversion`: + `reverse_bits`

Centril · 2019-01-11T19:45:03Z

@bors p=1

Giving prio since stabilization.

bors · 2019-01-11T22:13:46Z

⌛ Testing commit 14be8a7 with merge 3bdcaae5f6407317053565650e6aa76b45d20818...

bors · 2019-01-12T01:15:10Z

💔 Test failed - checks-travis

Centril · 2019-01-12T01:21:03Z

@bors retry

bors · 2019-01-12T02:00:27Z

⌛ Testing commit 14be8a7 with merge 0c91f3d...

@oli-obk

Const-stabilize `const_int_ops` + `const_ip` r? @oli-obk ## Note for relnotes: This PR includes #57105. I've added T-lang since this affects intrinsics and the operational semantics of Rust's `const fn` fragment. ## Stable APIs proposed for constification + `const_int_ops`: + `count_ones` + `count_zeros` + `leading_zeros` + `trailing_zeros` + `swap_bytes` + `from_be` + `from_le` + `to_be` + `to_le` + `const_ip` + `Ipv4Addr::new` ## Unstable APIs constified + `const_int_conversion`: + `reverse_bits`

bors · 2019-01-12T04:37:23Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 0c91f3d to master...

Pkgsrc changes: * Bump required rust version to build to 1.32.0. * Adapt patches to changed file locations. * Since we now patch some more vendor/ modules, doctor the corresponding .cargo-checksum.json files accordingly Upstream changes: Version 1.33.0 (2019-02-28) ========================== Language -------- - [You can now use the `cfg(target_vendor)` attribute.][57465] E.g. `#[cfg(target_vendor="apple")] fn main() { println!("Hello Apple!"); }` - [Integer patterns such as in a match expression can now be exhaustive.][56362] E.g. You can have match statement on a `u8` that covers `0..=255` and you would no longer be required to have a `_ => unreachable!()` case. - [You can now have multiple patterns in `if let` and `while let` expressions.][57532] You can do this with the same syntax as a `match` expression. E.g. ```rust enum Creature { Crab(String), Lobster(String), Person(String), } fn main() { let state = Creature::Crab("Ferris"); if let Creature::Crab(name) | Creature::Person(name) = state { println!("This creature's name is: {}", name); } } ``` - [You can now have irrefutable `if let` and `while let` patterns.][57535] Using this feature will by default produce a warning as this behaviour can be unintuitive. E.g. `if let _ = 5 {}` - [You can now use `let` bindings, assignments, expression statements, and irrefutable pattern destructuring in const functions.][57175] - [You can now call unsafe const functions.][57067] E.g. ```rust const unsafe fn foo() -> i32 { 5 } const fn bar() -> i32 { unsafe { foo() } } ``` - [You can now specify multiple attributes in a `cfg_attr` attribute.][57332] E.g. `#[cfg_attr(all(), must_use, optimize)]` - [You can now specify a specific alignment with the `#[repr(packed)]` attribute.][57049] E.g. `#[repr(packed(2))] struct Foo(i16, i32);` is a struct with an alignment of 2 bytes and a size of 6 bytes. - [You can now import an item from a module as an `_`.][56303] This allows you to import a trait's impls, and not have the name in the namespace. E.g. ```rust use std::io::Read as _; // Allowed as there is only one `Read` in the module. pub trait Read {} ``` - [You may now use `Rc`, `Arc`, and `Pin` as method receivers][56805]. Compiler -------- - [You can now set a linker flavor for `rustc` with the `-Clinker-flavor` command line argument.][56351] - [The mininum required LLVM version has been bumped to 6.0.][56642] - [Added support for the PowerPC64 architecture on FreeBSD.][57615] - [The `x86_64-fortanix-unknown-sgx` target support has been upgraded to tier 2 support.][57130] Visit the [platform support][platform-support] page for information on Rust's platform support. - [Added support for the `thumbv7neon-linux-androideabi` and `thumbv7neon-unknown-linux-gnueabihf` targets.][56947] - [Added support for the `x86_64-unknown-uefi` target.][56769] Libraries --------- - [The methods `overflowing_{add, sub, mul, shl, shr}` are now `const` functions for all numeric types.][57566] - [The methods `rotate_left`, `rotate_right`, and `wrapping_{add, sub, mul, shl, shr}` are now `const` functions for all numeric types.][57105] - [The methods `is_positive` and `is_negative` are now `const` functions for all signed numeric types.][57105] - [The `get` method for all `NonZero` types is now `const`.][57167] - [The methods `count_ones`, `count_zeros`, `leading_zeros`, `trailing_zeros`, `swap_bytes`, `from_be`, `from_le`, `to_be`, `to_le` are now `const` for all numeric types.][57234] - [`Ipv4Addr::new` is now a `const` function][57234] Stabilized APIs --------------- - [`unix::FileExt::read_exact_at`] - [`unix::FileExt::write_all_at`] - [`Option::transpose`] - [`Result::transpose`] - [`convert::identity`] - [`pin::Pin`] - [`marker::Unpin`] - [`marker::PhantomPinned`] - [`Vec::resize_with`] - [`VecDeque::resize_with`] - [`Duration::as_millis`] - [`Duration::as_micros`] - [`Duration::as_nanos`] Cargo ----- - [Cargo should now rebuild a crate if a file was modified during the initial build.][cargo/6484] Compatibility Notes ------------------- - The methods `str::{trim_left, trim_right, trim_left_matches, trim_right_matches}` are now deprecated in the standard library, and their usage will now produce a warning. Please use the `str::{trim_start, trim_end, trim_start_matches, trim_end_matches}` methods instead. - The `Error::cause` method has been deprecated in favor of `Error::source` which supports downcasting. [55982]: rust-lang/rust#55982 [56303]: rust-lang/rust#56303 [56351]: rust-lang/rust#56351 [56362]: rust-lang/rust#56362 [56642]: rust-lang/rust#56642 [56769]: rust-lang/rust#56769 [56805]: rust-lang/rust#56805 [56947]: rust-lang/rust#56947 [57049]: rust-lang/rust#57049 [57067]: rust-lang/rust#57067 [57105]: rust-lang/rust#57105 [57130]: rust-lang/rust#57130 [57167]: rust-lang/rust#57167 [57175]: rust-lang/rust#57175 [57234]: rust-lang/rust#57234 [57332]: rust-lang/rust#57332 [57465]: rust-lang/rust#57465 [57532]: rust-lang/rust#57532 [57535]: rust-lang/rust#57535 [57566]: rust-lang/rust#57566 [57615]: rust-lang/rust#57615 [cargo/6484]: rust-lang/cargo#6484 [`unix::FileExt::read_exact_at`]: https://doc.rust-lang.org/std/os/unix/fs/trait.FileExt.html#method.read_exact_at [`unix::FileExt::write_all_at`]: https://doc.rust-lang.org/std/os/unix/fs/trait.FileExt.html#method.write_all_at [`Option::transpose`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.transpose [`Result::transpose`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.transpose [`convert::identity`]: https://doc.rust-lang.org/std/convert/fn.identity.html [`pin::Pin`]: https://doc.rust-lang.org/std/pin/struct.Pin.html [`marker::Unpin`]: https://doc.rust-lang.org/stable/std/marker/trait.Unpin.html [`marker::PhantomPinned`]: https://doc.rust-lang.org/nightly/std/marker/struct.PhantomPinned.html [`Vec::resize_with`]: https://doc.rust-lang.org/std/vec/struct.Vec.html#method.resize_with [`VecDeque::resize_with`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.resize_with [`Duration::as_millis`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_millis [`Duration::as_micros`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_micros [`Duration::as_nanos`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_nanos [platform-support]: https://forge.rust-lang.org/platform-support.html

Centril added 10 commits December 31, 2018 03:36

stabilize const_int_wrapping.

7e7c337

stabilize const_int_rotate

e258489

stabilize const_int_sign

eb0597a

const stabilizations: adjust run-pass tests.

d85ec4a

unchecked_{shl,shr}: extend const tests.

35d77fc

qualify_min_const_fn: improve note.

e4c47f9

make some intrinsics safe.

fedfb61

now that some intrisics are safe, use that fact.

50152d2

const-stabilize const_int_ops + reverse_bits

2760f87

const-stabilize Ipv4Addr::new

14be8a7

Centril added T-lang Relevant to the language team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Dec 31, 2018

rust-highfive assigned oli-obk Dec 31, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 31, 2018

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Dec 31, 2018

Centril added the relnotes Marks issues that should be documented in the release notes of the next release. label Dec 31, 2018

Centril mentioned this pull request Dec 31, 2018

Summary issue for const-stabilizing const_int_overflowing #57237

Closed

Centril added I-nominated and removed I-nominated labels Jan 3, 2019

fbstj reviewed Jan 5, 2019

View reviewed changes

src/librustc_mir/transform/qualify_min_const_fn.rs Show resolved Hide resolved

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jan 8, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2019

Centril mentioned this pull request Jan 11, 2019

Rollup of 2 pull requests #57513

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 12, 2019

This comment has been minimized.

Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2019

bors merged commit 14be8a7 into rust-lang:master Jan 12, 2019

Centril deleted the const-stabilizations-2 branch January 12, 2019 04:38

Centril mentioned this pull request Jan 12, 2019

Stablilize const_int_{rotate,wrapping,sign} #57105

Closed

Lokathor mentioned this pull request Jan 12, 2019

Make wrapping_neg and overflowing_neg functions into const #57536

Closed

This was referenced Jan 13, 2019

Tracking Issue for more const int functions #53718

Closed

[tracking issue] const fn: count_zeros, count_ones, leading_zeros, trailing_zeros #51267

Closed

Centril removed the T-lang Relevant to the language team, which will review and decide on the PR/issue. label Jan 13, 2019

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jan 18, 2019

Bobo1239 mentioned this pull request Feb 1, 2019

Remove stabilized const_int_ops feature r-efi/r-efi#4

Closed

Centril added this to the 1.33 milestone Apr 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Const-stabilize `const_int_ops` + `const_ip` #57234

Const-stabilize `const_int_ops` + `const_ip` #57234

Centril commented Dec 31, 2018 •

edited

Loading

Centril commented Dec 31, 2018

rfcbot commented Dec 31, 2018 •

edited by aturon

Loading

rfcbot commented Jan 8, 2019

oli-obk commented Jan 11, 2019

bors commented Jan 11, 2019

Centril commented Jan 11, 2019

bors commented Jan 11, 2019

bors commented Jan 12, 2019

This comment has been minimized.

Centril commented Jan 12, 2019

bors commented Jan 12, 2019

bors commented Jan 12, 2019

Const-stabilize const_int_ops + const_ip #57234

Const-stabilize const_int_ops + const_ip #57234

Conversation

Centril commented Dec 31, 2018 • edited Loading

Note for relnotes: This PR includes #57105.

Stable APIs proposed for constification

Unstable APIs constified

Centril commented Dec 31, 2018

rfcbot commented Dec 31, 2018 • edited by aturon Loading

rfcbot commented Jan 8, 2019

oli-obk commented Jan 11, 2019

bors commented Jan 11, 2019

Centril commented Jan 11, 2019

bors commented Jan 11, 2019

bors commented Jan 12, 2019

This comment has been minimized.

Centril commented Jan 12, 2019

bors commented Jan 12, 2019

bors commented Jan 12, 2019

Const-stabilize `const_int_ops` + `const_ip` #57234

Const-stabilize `const_int_ops` + `const_ip` #57234

Centril commented Dec 31, 2018 •

edited

Loading

rfcbot commented Dec 31, 2018 •

edited by aturon

Loading