Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition librustdoc to Rust 2018 #58100

Merged
merged 2 commits into from
Feb 23, 2019
Merged

Transition librustdoc to Rust 2018 #58100

merged 2 commits into from
Feb 23, 2019

Conversation

h-michael
Copy link
Contributor

@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 3, 2019
@Centril Centril mentioned this pull request Feb 3, 2019
Closed
78 tasks
@GuillaumeGomez
Copy link
Member

Strange that the new rust version forces to add all this code... :-/

@h-michael
Copy link
Contributor Author

Sorry I check it :(

@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@Centril
Copy link
Contributor

Centril commented Feb 23, 2019

Ping from triage, @h-michael, the PR is in need of rebasing :)

r? @Centril

I would prefer to not run rustfmt on this crate to keep the changes more limited and do targeted fixes re. tidy checks.

@h-michael
Copy link
Contributor Author

@Centril I've fixed it.

@rust-highfive

This comment has been minimized.

Sign in to view
@Centril
Copy link
Contributor

Centril commented Feb 23, 2019

Thanks! @bors r+

@bors
Copy link
Contributor

bors commented Feb 23, 2019

📌 Commit 1fe87df has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2019
Centril added a commit to Centril/rust that referenced this pull request Feb 23, 2019
@Centril
Rollup merge of rust-lang#58100 - h-michael:librustdoc-2018, r=Centril
c49da5b 
Transition librustdoc to Rust 2018

rust-lang#58099
@Centril Centril mentioned this pull request Feb 23, 2019
Merged
bors added a commit that referenced this pull request Feb 23, 2019
@bors
Auto merge of #58669 - Centril:rollup, r=Centril
7f19f16 
Rollup of 16 pull requests

Successful merges:

 - #58100 (Transition librustdoc to Rust 2018)
 - #58122 (RangeInclusive internal iteration performance improvement.)
 - #58199 (Add better error message for partial move)
 - #58227 (Updated RELEASES.md for 1.33.0)
 - #58353 (Check the Self-type of inherent associated constants)
 - #58453 (SGX target: fix panic = abort)
 - #58476 (Remove `LazyTokenStream`.)
 - #58526 (Special suggestion for illegal unicode curly quote pairs)
 - #58595 (Turn duration consts into associated consts)
 - #58609 (Allow Self::Module to be mutated.)
 - #58628 (Optimise vec![false; N] to zero-alloc)
 - #58643 (Don't generate minification variables if minification disabled)
 - #58648 (Update tests to account for cross-platform testing and miri.)
 - #58654 (Do not underflow after resetting unmatched braces count)
 - #58658 (Add expected/provided byte alignments to validation error message)
 - #58667 (Reduce Miri-related Code Repetition `like (n << amt) >> amt`)

Failed merges:

r? @ghost
@bors bors merged commit 1fe87df into rust-lang:master Feb 23, 2019
tspiteri added a commit to tspiteri/rust that referenced this pull request Feb 23, 2019
@tspiteri
fix build for Rust 2018 now that rust-lang#58100 has been merged
aa0fa75
@tspiteri tspiteri mentioned this pull request Feb 23, 2019
Merged
@h-michael h-michael deleted the librustdoc-2018 branch February 24, 2019 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez left review comments

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

@Centril Centril Centril approved these changes

Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@h-michael @rust-highfive @GuillaumeGomez @bors @Centril @Mark-Simulacrum