Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially Hiridify typeck #58153

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Partially Hiridify typeck #58153

merged 1 commit into from
Feb 11, 2019

Conversation

ljedrz
Copy link
Contributor

@ljedrz ljedrz commented Feb 4, 2019

Another step towards #57578.

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 4, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:2a2cb7b0:start=1549295283505722831,finish=1549295289797450337,duration=6291727506
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:15:44]    Compiling rustc_typeck v0.0.0 (/checkout/src/librustc_typeck)
[00:15:46] error[E0308]: mismatched types
[00:15:46]    --> src/librustc_metadata/encoder.rs:677:58
[00:15:46]     |
[00:15:46] 677 |         let variant_data = tcx.hir().expect_variant_data(variant_id);
[00:15:46]     |                                                          ^^^^^^^^^^ expected struct `rustc::hir::HirId`, found struct `syntax::ast::NodeId`
[00:15:46]     = note: expected type `rustc::hir::HirId`
[00:15:46]                found type `syntax::ast::NodeId`
[00:15:46] 
[00:15:48] error: aborting due to previous error
---
[00:20:58] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--message-format" "json"
[00:20:58] expected success, got: exit code: 101
[00:20:58] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:20:58] Build completed unsuccessfully in 0:14:41
[00:20:58] Makefile:18: recipe for target 'all' failed
[00:20:58] make: *** [all] Error 1
24792 ./src/llvm-project/compiler-rt/test/builtins/Unit
24128 ./src/llvm-project/lldb/packages
24124 ./src/llvm-project/lldb/packages/Python
24120 ./src/llvm-project/lldb/packages/Python/lldbsuite
---
travis_time:end:04f1cbee:start=1549296558444535015,finish=1549296559040536449,duration=596001434
travis_fold:end:after_failure.1
travis_fold:start:after_failure.2
travis_time:start:09e1b688
$ ls -lat $HOME/Library/Logs/Diagnosti/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0e34b287
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@ljedrz
Copy link
Contributor Author

ljedrz commented Feb 5, 2019

Rebased.

@Zoxc
Copy link
Contributor

Zoxc commented Feb 5, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Feb 5, 2019

📌 Commit 6da9129 has been approved by Zoxc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2019
@ljedrz ljedrz mentioned this pull request Feb 6, 2019
@Zoxc
Copy link
Contributor

Zoxc commented Feb 6, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Feb 6, 2019

📌 Commit 6da9129 has been approved by Zoxc

kennytm added a commit to kennytm/rust that referenced this pull request Feb 8, 2019
Partially Hiridify typeck

Another step towards rust-lang#57578.
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Feb 10, 2019
Partially Hiridify typeck

Another step towards rust-lang#57578.
@bors
Copy link
Contributor

bors commented Feb 11, 2019

⌛ Testing commit 6da9129 with merge 576df31...

bors added a commit that referenced this pull request Feb 11, 2019
Partially Hiridify typeck

Another step towards #57578.
@bors
Copy link
Contributor

bors commented Feb 11, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Zoxc
Pushing 576df31 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 11, 2019
@bors bors merged commit 6da9129 into rust-lang:master Feb 11, 2019
@ljedrz ljedrz deleted the HirIdify_typeck branch February 11, 2019 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants