Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ? in librustc macros #58313

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Conversation

matthewjasper
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 8, 2019
@mark-i-m
Copy link
Member

mark-i-m commented Feb 9, 2019

Thanks! I had been meaning to do this :)

src/librustc/macros.rs Outdated Show resolved Hide resolved
@oli-obk
Copy link
Contributor

oli-obk commented Feb 10, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Feb 10, 2019

📌 Commit 0a16b87 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2019
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Feb 10, 2019
Centril added a commit to Centril/rust that referenced this pull request Feb 12, 2019
bors added a commit that referenced this pull request Feb 12, 2019
Rollup of 11 pull requests

Successful merges:

 - #58105 (libarena => 2018)
 - #58111 (libterm => 2018)
 - #58287 (rustc-std-workspace-core => 2018)
 - #58288 (rustc-workspace-hack => 2018)
 - #58300 (librustc_typeck => 2018)
 - #58313 (Use `?` in librustc macros)
 - #58318 (libserialize => 2018)
 - #58322 (librustc_codegen_ssa => 2018)
 - #58342 (Revert removed #![feature(nll)])
 - #58367 (Remove two dead functions.)
 - #58382 (docs: remove "experimental" wording from std::os::unix)

Failed merges:

r? @ghost
@bors bors merged commit 0a16b87 into rust-lang:master Feb 12, 2019
@matthewjasper matthewjasper deleted the use-question-in-macros branch February 23, 2019 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants