Add a -Z time option which prints only passes which runs once #58507

Zoxc · 2019-02-16T07:59:38Z

This ensures -Z time-passes fits on my screen =P

michaelwoerister · 2019-02-19T13:05:43Z

What does it do?

Zoxc · 2019-02-19T13:14:31Z

src/librustc_typeck/coherence/mod.rs

@@ -133,9 +133,7 @@ fn coherent_trait<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>, def_id: DefId) {
    for &impl_id in impls {
        check_impl_overlap(tcx, impl_id);
    }
-    use rustc::util::common::time;
-    time(tcx.sess, "builtin::check_trait checking", ||
-          builtin::check_trait(tcx, def_id));


I added this for profiling purposes, but forgot to remove it.

Zoxc · 2019-02-19T13:16:24Z

-Z time-extended does what -Z time-passes currently does. While -Z time-passes is changed to only show passes which run once.

michaelwoerister · 2019-02-21T12:22:18Z

I'd prefer not to change the behaviour of -Ztime-passes. Would you be OK with making -Ztime-passes take an argument for the behaviour you want and letting it default to the current behaviour? So -Ztime-passes would do the same as now but one can do -Ztime-passes=reduced to get the smaller output.

Zoxc · 2019-03-02T17:49:27Z

I think I'd rather add a -Z time option, which defaults to the smaller output.

bors · 2019-03-03T22:55:55Z

☔ The latest upstream changes (presumably #58425) made this pull request unmergeable. Please resolve the merge conflicts.

michaelwoerister · 2019-03-04T10:46:55Z

That's fine too. I just don't want to change the behaviour of -Ztime-passes unnecessarily.

Dylan-DPC-zz · 2019-03-11T22:04:59Z

ping from triage @Zoxc any updates on this?

TimNN · 2019-03-19T16:49:41Z

Ping from triage @Zoxc: What is the status of this PR?

Centril · 2019-03-30T12:48:02Z

Ping from triage, @michaelwoerister thoughts?

michaelwoerister · 2019-04-01T09:58:51Z

Oh, I didn't see that an update was pushed here.
@bors r+

bors · 2019-04-01T09:58:52Z

📌 Commit e842f57 has been approved by michaelwoerister

bors · 2019-04-01T09:59:07Z

⌛ Testing commit e842f57 with merge cbcc4e7e87d77a59a427d94a45d9ea5b4962da5a...

bors · 2019-04-01T13:59:07Z

💥 Test timed out

Centril · 2019-04-01T14:00:25Z

@bors retry

@michaelwoerister

Add a -Z time option which prints only passes which runs once This ensures `-Z time-passes` fits on my screen =P r? @michaelwoerister

@ghost

Rollup of 7 pull requests Successful merges: - #58507 (Add a -Z time option which prints only passes which runs once) - #58919 (Suggest using anonymous lifetime in `impl Trait` return) - #59041 (fixes #56766) - #59586 (Fixed URL in cargotest::TEST_REPOS) - #59595 (Update rustc-guide submodule) - #59601 (Fix small typo) - #59603 (stabilize ptr::hash) Failed merges: r? @ghost

@michaelwoerister

Add a RUSTC_TIME env var to time rust crates during bootstrap Blocked on rust-lang/cargo#6674 r? @michaelwoerister Example for rustc with #58507: ``` time: 0.460; rss: 94MB parsing time: 0.000; rss: 94MB attributes injection time: 0.000; rss: 94MB recursion limit time: 0.000; rss: 94MB crate injection time: 0.000; rss: 94MB plugin loading time: 0.000; rss: 94MB plugin registration time: 0.044; rss: 94MB pre ast expansion lint checks time: 1.999; rss: 316MB expand crate time: 0.000; rss: 316MB check unused macros time: 2.000; rss: 316MB expansion time: 0.000; rss: 316MB maybe building test harness time: 0.053; rss: 316MB AST validation time: 0.000; rss: 316MB maybe creating a macro crate time: 1.515; rss: 397MB name resolution time: 0.122; rss: 397MB complete gated feature checking time: 0.655; rss: 546MB lowering ast -> hir time: 0.136; rss: 550MB early lint checks time: 0.117; rss: 540MB validate hir map time: 0.606; rss: 540MB indexing hir time: 0.000; rss: 480MB load query result cache time: 0.000; rss: 478MB dep graph tcx init time: 0.000; rss: 478MB looking for entry point time: 0.001; rss: 478MB looking for plugin registrar time: 0.001; rss: 478MB looking for derive registrar time: 0.049; rss: 478MB loop checking time: 0.064; rss: 479MB attribute checking time: 0.166; rss: 484MB stability checking time: 0.699; rss: 566MB type collecting time: 0.006; rss: 566MB outlives testing time: 0.018; rss: 568MB impl wf inference time: 0.002; rss: 583MB unsafety checking time: 0.005; rss: 583MB orphan checking time: 0.227; rss: 583MB coherence checking time: 0.006; rss: 583MB variance testing time: 1.546; rss: 657MB wf checking time: 0.389; rss: 665MB item-types checking time: 13.999; rss: 837MB item-bodies checking time: 1.692; rss: 883MB rvalue promotion time: 0.067; rss: 883MB intrinsic checking time: 0.624; rss: 887MB match checking time: 0.246; rss: 889MB liveness checking time: 2.629; rss: 889MB misc checking time: 0.000; rss: 889MB borrow checking time: 16.754; rss: 1242MB MIR borrow checking time: 0.050; rss: 1242MB dumping chalk-like clauses time: 0.010; rss: 1242MB MIR effect checking time: 0.001; rss: 1242MB layout testing time: 0.829; rss: 1244MB privacy checking time: 0.183; rss: 1247MB death checking time: 0.100; rss: 1248MB unused lib feature checking time: 0.405; rss: 1250MB lint checking time: 1.518; rss: 1250MB misc checking time: 0.000; rss: 1250MB resolving dependency formats time: 2.928; rss: 1332MB write metadata time: 0.014; rss: 1332MB collecting roots time: 7.621; rss: 1488MB collecting mono items time: 7.635; rss: 1488MB monomorphization collection time: 0.557; rss: 1567MB codegen unit partitioning time: 27.971; rss: 2656MB codegen to LLVM IR time: 0.056; rss: 2656MB assert dep graph time: 0.000; rss: 2656MB serialize dep graph time: 195.414; rss: 2656MB codegen time: 0.000; rss: 329MB serialize work products time: 1.664; rss: 331MB running linker time: 1.965; rss: 331MB linking [RUSTC-TIMING] rustc test:false 950.103 ``` It doesn't really look like the times add up here.

rust-highfive assigned michaelwoerister Feb 16, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 16, 2019

Zoxc force-pushed the time-extended branch from da7db86 to ad8409e Compare February 16, 2019 08:00

Zoxc mentioned this pull request Feb 16, 2019

Add a RUSTC_TIME env var to time rust crates during bootstrap #58508

Merged

Zoxc commented Feb 19, 2019

View reviewed changes

michaelwoerister added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 22, 2019

Add a -Z time option which prints only passes which runs once

e842f57

Zoxc force-pushed the time-extended branch from ad8409e to e842f57 Compare March 20, 2019 07:03

Zoxc changed the title ~~Add a -Z time-extended option for passes which can run multiple times~~ Add a -Z time option which prints only passes which runs once Mar 20, 2019

Centril added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 30, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 1, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2019

Centril mentioned this pull request Apr 1, 2019

Rollup of 7 pull requests #59606

Merged

bors merged commit e842f57 into rust-lang:master Apr 1, 2019

Zoxc deleted the time-extended branch April 1, 2019 22:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a -Z time option which prints only passes which runs once #58507

Add a -Z time option which prints only passes which runs once #58507

Zoxc commented Feb 16, 2019

michaelwoerister commented Feb 19, 2019

Zoxc Feb 19, 2019

Zoxc commented Feb 19, 2019

michaelwoerister commented Feb 21, 2019

Zoxc commented Mar 2, 2019

bors commented Mar 3, 2019

michaelwoerister commented Mar 4, 2019

Dylan-DPC-zz commented Mar 11, 2019

TimNN commented Mar 19, 2019

Centril commented Mar 30, 2019

michaelwoerister commented Apr 1, 2019

bors commented Apr 1, 2019

bors commented Apr 1, 2019

bors commented Apr 1, 2019

Centril commented Apr 1, 2019

Add a -Z time option which prints only passes which runs once #58507

Add a -Z time option which prints only passes which runs once #58507

Conversation

Zoxc commented Feb 16, 2019

michaelwoerister commented Feb 19, 2019

Zoxc Feb 19, 2019

Choose a reason for hiding this comment

Zoxc commented Feb 19, 2019

michaelwoerister commented Feb 21, 2019

Zoxc commented Mar 2, 2019

bors commented Mar 3, 2019

michaelwoerister commented Mar 4, 2019

Dylan-DPC-zz commented Mar 11, 2019

TimNN commented Mar 19, 2019

Centril commented Mar 30, 2019

michaelwoerister commented Apr 1, 2019

bors commented Apr 1, 2019

bors commented Apr 1, 2019

bors commented Apr 1, 2019

Centril commented Apr 1, 2019