Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the identifier span for missing struct field #59240

Merged
merged 1 commit into from
Mar 25, 2019
Merged

use the identifier span for missing struct field #59240

merged 1 commit into from
Mar 25, 2019

Conversation

euclio
Copy link
Contributor

@euclio euclio commented Mar 16, 2019

No description provided.

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 16, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Mar 16, 2019

r? @oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned eddyb Mar 16, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Mar 16, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Mar 16, 2019

📌 Commit b392c5e has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2019
sanxiyn added a commit to sanxiyn/rust that referenced this pull request Mar 18, 2019
@sanxiyn
Rollup merge of rust-lang#59240 - euclio:struct-field-span, r=oli-obk
859c9a5 
use the identifier span for missing struct field
@sanxiyn sanxiyn mentioned this pull request Mar 18, 2019
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Mar 22, 2019
@Mark-Simulacrum
Rollup merge of rust-lang#59240 - euclio:struct-field-span, r=oli-obk
20211eb 
use the identifier span for missing struct field
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Mar 22, 2019
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Mar 23, 2019
@Mark-Simulacrum
Rollup merge of rust-lang#59240 - euclio:struct-field-span, r=oli-obk
6f59f9a 
use the identifier span for missing struct field
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Mar 23, 2019
Closed
@bors
Copy link
Contributor

bors commented Mar 25, 2019

⌛ Testing commit b392c5e with merge 60eca54...

bors added a commit that referenced this pull request Mar 25, 2019
@bors
Auto merge of #59240 - euclio:struct-field-span, r=oli-obk
60eca54 
use the identifier span for missing struct field
@bors
Copy link
Contributor

bors commented Mar 25, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 60eca54 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 25, 2019
@bors bors merged commit b392c5e into rust-lang:master Mar 25, 2019
@euclio euclio deleted the struct-field-span branch March 25, 2019 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@euclio @rust-highfive @oli-obk @bors @eddyb