Revert rust-lld place changes #59672
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ p=1 (regression fix that we should test asap) |
|
📌 Commit 5b292ec has been approved by |
bors
added
S-waiting-on-bors
| @@ -518,8 +518,7 @@ impl Step for Rustc { | |||
| .join("bin") | |||
| .join(&exe); | |||
| // for the rationale about this rename check `compile::copy_lld_to_sysroot` | |||
| let dst = image.join(libdir_relative) | |||
| .join("rustlib") | |||
| let dst = image.join("lib/rustlib") | |||
There was a problem hiding this comment.
Joining / on Windows is a bad idea, in case the path ever turns out to be a //?/ path which only understands \.
There was a problem hiding this comment.
"lib/rustlib" used here before also it used on other places as well.
|
⌛ Testing commit 5b292ec with merge 17596752980f11debabe151a007bf633f30d40b8... |
Revert rust-lld place changes Fixes rust-lang#59661. Instead of rust-lang#59668 it reverts only failed part.
|
⌛ Testing commit 5b292ec with merge 8fda69b8875189d5b60d469f6ef0bbac58de3a8d... |
|
@bors retry |
|
⌛ Testing commit 5b292ec with merge 4cd873eafcc7f0c662c5216d41b9ce2af2d64bbc... |
Revert rust-lld place changes Fixes rust-lang#59661. Instead of rust-lang#59668 it reverts only failed part.
|
☀️ Test successful - checks-travis, status-appveyor |
|
Location of |
Fixes #59661.
Instead of #59668 it reverts only failed part.