Removed ascii functions from other modules #6029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let kind = str::to_lower(str::slice(line, start_kind, idx).to_owned()); | ||
|
|
||
| // FIXME: 4318 Instead of to_str_ascii, could use | ||
| // to_str_consume to not do a unneccessary copy. |
There was a problem hiding this comment.
typo: unneccessary -> unnecessary
There was a problem hiding this comment.
Urgh, of course that happens in a piece of code I copy pasted at like 10 different places...
|
It seems the failure is not caused by a test failure? |
Replaced str::to_lowercase and str::to_uppercase
bors
added a commit
that referenced
this pull request
Apr 24, 2013
Replaced {str, char, u8}::is_ascii
Replaced str::to_lower and str::to_upper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced {str, char, u8}::is_ascii
Replaced str::to_lower and str::to_upper