-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 5 pull requests #62452
Rollup of 5 pull requests #62452
Commits on Apr 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 89feb6d - Browse repository at this point
Copy the full SHA 89feb6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for a580421 - Browse repository at this point
Copy the full SHA a580421View commit details -
Configuration menu - View commit details
-
Copy full SHA for edbc27d - Browse repository at this point
Copy the full SHA edbc27dView commit details
Commits on Apr 19, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 2c9c978 - Browse repository at this point
Copy the full SHA 2c9c978View commit details
Commits on Jun 10, 2019
-
Apply suggestions from code review
Co-Authored-By: varkor <github@varkor.com>
Configuration menu - View commit details
-
Copy full SHA for 60ccf89 - Browse repository at this point
Copy the full SHA 60ccf89View commit details
Commits on Jun 15, 2019
-
Make the Weak::{into,as}_raw methods
Because Weak doesn't Deref, so there's no reason for them to be only associated methods.
Configuration menu - View commit details
-
Copy full SHA for 49fbd76 - Browse repository at this point
Copy the full SHA 49fbd76View commit details
Commits on Jul 1, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 2b47a08 - Browse repository at this point
Copy the full SHA 2b47a08View commit details
Commits on Jul 5, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 05c1e92 - Browse repository at this point
Copy the full SHA 05c1e92View commit details
Commits on Jul 6, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 42c3d37 - Browse repository at this point
Copy the full SHA 42c3d37View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7646d49 - Browse repository at this point
Copy the full SHA 7646d49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15042a3 - Browse repository at this point
Copy the full SHA 15042a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22d6d8a - Browse repository at this point
Copy the full SHA 22d6d8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ab112ca - Browse repository at this point
Copy the full SHA ab112caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 987be89 - Browse repository at this point
Copy the full SHA 987be89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 920a17a - Browse repository at this point
Copy the full SHA 920a17aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3274507 - Browse repository at this point
Copy the full SHA 3274507View commit details -
normalize use of backticks/lowercase in compiler messages for librust…
…c_mir rust-lang#60532 r? @alexreg
Samy Kacimi committedJul 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 7a2a17a - Browse repository at this point
Copy the full SHA 7a2a17aView commit details -
Rollup merge of rust-lang#60081 - pawroman:cleanup_unicode_script, r=…
…varkor Refactor unicode.py script Hi, I noticed that the `unicode.py` script used some deprecated escapes in regular expressions. E.g. `\d`, `\w`, `\.` will be illegal in the future without "raw strings". This is now fixed. I have also cleaned up the script quite a bit. ## Escape deprecation OK (note the `r`): `re.compile(r"\d")` Deprecated (from Python 3.6 onwards, see [here][link1] and [here][link2]): `re.compile("\d")`. [link1]: https://docs.python.org/3.6/whatsnew/3.6.html#deprecated-python-behavior [link2]: https://bugs.python.org/issue27364 This was evident running the script using Python 3.7 like so: ``` $ python3 -Wall unicode.py unicode.py:227: DeprecationWarning: invalid escape sequence \w re1 = re.compile("^ *([0-9A-F]+) *; *(\w+)") unicode.py:228: DeprecationWarning: invalid escape sequence \. re2 = re.compile("^ *([0-9A-F]+)\.\.([0-9A-F]+) *; *(\w+)") unicode.py:453: DeprecationWarning: invalid escape sequence \d pattern = "for Version (\d+)\.(\d+)\.(\d+) of the Unicode" ``` The documentation states that > A backslash-character pair that is not a valid escape sequence now generates a DeprecationWarning. Although this will eventually become a SyntaxError, that will not be for several Python releases. ## Testing To test my changes, I had to add support for choosing the Unicode version to use. The script will default to latest release (which is 12.0.0 at the moment, repo has 11.0.0 checked in). The script generates the exact same output for version 11.0.0 with Python 2.7 and 3.7 and no longer generates any deprecation warnings: ``` $ python3 -Wall unicode.py -v 11.0.0 Using Unicode version: 11.0.0 Regenerated tables.rs. $ git diff tables.rs $ python2 -Wall unicode.py -v 11.0.0 Using Unicode version: 11.0.0 Regenerated tables.rs. $ git diff tables.rs $ python2 --version Python 2.7.16 $ python3 --version Python 3.7.3 ``` ## Extra functionality Furthermore, the script will check and download the latest Unicode version by default (without the `-v` argument). The `--help` is below: ``` $ ./unicode.py --help usage: unicode.py [-h] [-v VERSION] Regenerate Unicode tables (tables.rs). optional arguments: -h, --help show this help message and exit -v VERSION, --version VERSION Unicode version to use (if not specified, defaults to latest available final release). ``` ## Cleanups I have cleaned up the code quite a bit, with Python best practices and code style in mind. I'm happy to provide more details and rationale for all my changes if the reviewers so desire. One externally visible change is that the Unicode data will now be downloaded into `src/libcore/unicode/downloaded` directory suffixed by Unicode version: ``` $ pwd .../rust/src/libcore/unicode $ exa -T downloaded/ downloaded ├── 11.0.0 │ ├── DerivedCoreProperties.txt │ ├── DerivedNormalizationProps.txt │ ├── PropList.txt │ ├── ReadMe.txt │ ├── Scripts.txt │ ├── SpecialCasing.txt │ └── UnicodeData.txt └── 12.0.0 ├── DerivedCoreProperties.txt ├── DerivedNormalizationProps.txt ├── PropList.txt ├── ReadMe.txt ├── Scripts.txt ├── SpecialCasing.txt └── UnicodeData.txt ```
Configuration menu - View commit details
-
Copy full SHA for 327c54e - Browse repository at this point
Copy the full SHA 327c54eView commit details -
Rollup merge of rust-lang#61862 - vorner:weak-into-raw-methods, r=sfa…
…ckler Make the Weak::{into,as}_raw methods Because Weak doesn't Deref, so there's no reason for them to be only associated methods. As kindly pointed out here rust-lang#60766 (comment) by @chpio.
Configuration menu - View commit details
-
Copy full SHA for 296e825 - Browse repository at this point
Copy the full SHA 296e825View commit details -
Rollup merge of rust-lang#62243 - petrochenkov:macrodoc, r=eddyb
Improve documentation for built-in macros This is the `libcore` part of rust-lang#62086. Right now the only effect is improved documentation. The changes in the last few commits are required to make the `libcore` change compile successfully.
Configuration menu - View commit details
-
Copy full SHA for 154726c - Browse repository at this point
Copy the full SHA 154726cView commit details -
Rollup merge of rust-lang#62422 - lzutao:remove-some-mem-uinit, r=ale…
…xcrichton Remove some uses of mem::uninitialized cc rust-lang#62397 r? @RalfJung
Configuration menu - View commit details
-
Copy full SHA for 30e4a87 - Browse repository at this point
Copy the full SHA 30e4a87View commit details -
Rollup merge of rust-lang#62436 - fakenine:normalize_use_of_backticks…
…_compiler_messages_1, r=Centril normalize use of backticks/lowercase in compiler messages for librustc_mir normalize use of backticks/lowercase in compiler messages for librustc_mir rust-lang#60532 r? @alexreg
Configuration menu - View commit details
-
Copy full SHA for 7ef02dc - Browse repository at this point
Copy the full SHA 7ef02dcView commit details