Stabilize checked_duration_since for 1.39.0 #62860

vi · 2019-07-21T22:10:59Z

Looks like it has already found some use in projects.

Resolves #58402.

rust-highfive · 2019-07-21T22:11:03Z

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

Centril · 2019-07-21T22:31:00Z

r? @dtolnay

joelpalmer · 2019-07-29T10:53:54Z

Ping from Triage. @dtolnay @rust-lang/libs checking on the status of a review for this PR.

alexcrichton · 2019-07-29T14:46:18Z

Looks reasonable to me to merge, so let's...

@rfcbot fcp merge

New functions here are:

impl Instant {
    pub fn checked_duration_since(&self, earlier: Instant) -> Option<Duration>;
    pub fn saturating_duration_since(&self, earlier: Instant) -> Duration;
}

rfcbot · 2019-07-29T14:48:32Z

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2019-07-30T19:24:26Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot · 2019-08-09T19:26:04Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

alexcrichton · 2019-08-09T19:48:10Z

@bors: r+

bors · 2019-08-09T19:48:11Z

📌 Commit 01d9e57 has been approved by alexcrichton

…, r=alexcrichton Stabilize checked_duration_since for 1.38.0 Looks like it has already found some use in projects. Resolves rust-lang#58402.

Centril · 2019-09-01T10:20:25Z

r? @Mark-Simulacrum

vi · 2019-09-04T21:44:16Z

S-waiting-on-author

What to do now?

Shall I try renaming to tidy_test_never_used_anywhere_else and implementing it in Tidy?

Mark-Simulacrum · 2019-09-04T21:59:20Z

I believe if you change the line I pointed to have a feature name that is not checked_duration_since, everything should work.

Mark-Simulacrum · 2019-09-04T22:34:24Z

r=me with this all squashed into one or two commits (I'd personally separate out the tidy fix but doesn't matter too much) as well as a rebase

vi · 2019-09-04T22:51:09Z

r=me

Means "abandon this pull request and submit the new one, specifying r? Mark-Simulacrum in the opening comment"?

Or just rebase and force-push in place?

vi · 2019-09-04T22:57:42Z

... submit the new one ..., or rebase and force-push?

Went with the latter. Can rollback if needed.

Resolves rust-lang#58402.

Mark-Simulacrum · 2019-09-04T23:00:57Z

Yep, rebase and force-push is perfect.

@bors r+

bors · 2019-09-04T23:00:59Z

📌 Commit 5545582 has been approved by Mark-Simulacrum

…, r=Mark-Simulacrum Stabilize checked_duration_since for 1.38.0 Looks like it has already found some use in projects. Resolves rust-lang#58402.

@ghost

Rollup of 15 pull requests Successful merges: - #62860 (Stabilize checked_duration_since for 1.38.0) - #63549 (Rev::rposition counts from the wrong end) - #63985 (Stabilize pin_into_inner in 1.39.0) - #64005 (Add a `Place::is_indirect` method to determine whether a `Place` contains a `Deref` projection) - #64031 (Harden `param_attrs` test wrt. usage of a proc macro `#[attr]`) - #64038 (Check impl trait substs when checking for recursive types) - #64043 (Add some more tests for underscore imports) - #64092 (Update xLTO compatibility table in rustc book.) - #64110 (Refer to "`self` type" instead of "receiver type") - #64120 (Move path parsing earlier) - #64123 (Added warning around code with reference to uninit bytes) - #64128 (unused_parens: account for or-patterns and `&(mut x)`) - #64141 (Minimize uses of `LocalInternedString`) - #64142 (Fix doc links in `std::cmp` module) - #64148 (fix a few typos in comments) Failed merges: r? @ghost

bors · 2019-09-05T06:06:30Z

☔ The latest upstream changes (presumably #64160) made this pull request unmergeable. Please resolve the merge conflicts.

vi · 2019-09-05T08:30:29Z

The latest upstream changes (presumably <rollup that includes this PR>) made this pull request unmergeable

bors added [S-waiting-on-author] and removed [S-waiting-on-bors]

Bot error?

Mark-Simulacrum · 2019-09-05T15:09:54Z

Yeah, there's been an uptick in that recently, not sure why. Should be all good though.

RalfJung · 2019-09-13T08:47:48Z

(FWIW, the PR title is wrong now, it should mention 1.39.0.)

rust-highfive assigned cramertj Jul 21, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 21, 2019

Centril added this to the 1.38 milestone Jul 21, 2019

Centril added relnotes Marks issues that should be documented in the release notes of the next release. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. needs-fcp This change is insta-stable, so needs a completed FCP to proceed. labels Jul 21, 2019

rust-highfive assigned dtolnay and unassigned cramertj Jul 21, 2019

est31 mentioned this pull request Jul 22, 2019

Compiling libra on stable Rust diem/diem#270

Closed

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 29, 2019

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jul 30, 2019

Centril added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2019

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Aug 9, 2019

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 9, 2019

Centril removed S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. needs-fcp This change is insta-stable, so needs a completed FCP to proceed. labels Aug 9, 2019

rust-highfive assigned Mark-Simulacrum and unassigned Centril Sep 1, 2019

alexcrichton mentioned this pull request Sep 4, 2019

Tracking issue for 'checked_duration_since' feature #58402

Closed

vi force-pushed the stabilize_checked_duration_since branch from bb1bbe3 to 9d3cfae Compare September 4, 2019 22:57

vi added 2 commits September 5, 2019 01:58

Stabilize checked_duration_since for 1.39.0

843fba3

Resolves rust-lang#58402.

Avoid feature name 'checked_duration_since' in a Tidy test

5545582

vi force-pushed the stabilize_checked_duration_since branch from 9d3cfae to 5545582 Compare September 4, 2019 22:58

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 4, 2019

Centril mentioned this pull request Sep 5, 2019

Rollup of 15 pull requests #64159

Closed

Centril mentioned this pull request Sep 5, 2019

Rollup of 15 pull requests #64160

Merged

bors merged commit 5545582 into rust-lang:master Sep 5, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 5, 2019

vi changed the title ~~Stabilize checked_duration_since for 1.38.0~~ Stabilize checked_duration_since for 1.39.0 Sep 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize checked_duration_since for 1.39.0 #62860

Stabilize checked_duration_since for 1.39.0 #62860

vi commented Jul 21, 2019

rust-highfive commented Jul 21, 2019

Centril commented Jul 21, 2019

joelpalmer commented Jul 29, 2019

alexcrichton commented Jul 29, 2019

rfcbot commented Jul 29, 2019 •

edited by dtolnay

Loading

rfcbot commented Jul 30, 2019

rfcbot commented Aug 9, 2019

alexcrichton commented Aug 9, 2019

bors commented Aug 9, 2019

Centril commented Sep 1, 2019

vi commented Sep 4, 2019

Mark-Simulacrum commented Sep 4, 2019

Mark-Simulacrum commented Sep 4, 2019

vi commented Sep 4, 2019

vi commented Sep 4, 2019

Mark-Simulacrum commented Sep 4, 2019

bors commented Sep 4, 2019

bors commented Sep 5, 2019

vi commented Sep 5, 2019

Mark-Simulacrum commented Sep 5, 2019

RalfJung commented Sep 13, 2019

Stabilize checked_duration_since for 1.39.0 #62860

Stabilize checked_duration_since for 1.39.0 #62860

Conversation

vi commented Jul 21, 2019

rust-highfive commented Jul 21, 2019

Centril commented Jul 21, 2019

joelpalmer commented Jul 29, 2019

alexcrichton commented Jul 29, 2019

rfcbot commented Jul 29, 2019 • edited by dtolnay Loading

rfcbot commented Jul 30, 2019

rfcbot commented Aug 9, 2019

alexcrichton commented Aug 9, 2019

bors commented Aug 9, 2019

Centril commented Sep 1, 2019

vi commented Sep 4, 2019

Mark-Simulacrum commented Sep 4, 2019

Mark-Simulacrum commented Sep 4, 2019

vi commented Sep 4, 2019

vi commented Sep 4, 2019

Mark-Simulacrum commented Sep 4, 2019

bors commented Sep 4, 2019

bors commented Sep 5, 2019

vi commented Sep 5, 2019

Mark-Simulacrum commented Sep 5, 2019

RalfJung commented Sep 13, 2019

rfcbot commented Jul 29, 2019 •

edited by dtolnay

Loading