Back out #62150 (Implement mem::{zeroed,uninitialized} in terms of MaybeUninit) #63343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
RalfJung
reviewed
Aug 7, 2019
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Aug 7, 2019
Revert "uninit intrinsic is gone" This reverts commit fa290f1. Uninit is [being reinstated](rust-lang/rust#63343) because it breaks some broken code.
|
r? @RalfJung |
ishitatsuyuki
force-pushed
the
revert-62150
branch
from
710399a
to
77dcdca
Compare
|
I went with an amend, so technically this is no longer a revert. Is that fine? |
This comment has been minimized.
This comment has been minimized.
|
Out of time today, will fix it later. |
RalfJung
reviewed
Aug 9, 2019
ishitatsuyuki
force-pushed
the
revert-62150
branch
from
77dcdca
to
633548d
Compare
This comment has been minimized.
This comment has been minimized.
ishitatsuyuki
force-pushed
the
revert-62150
branch
from
633548d
to
20326f4
Compare
This comment has been minimized.
This comment has been minimized.
ishitatsuyuki
force-pushed
the
revert-62150
branch
from
20326f4
to
5af094b
Compare
This comment has been minimized.
This comment has been minimized.
ishitatsuyuki
force-pushed
the
revert-62150
branch
from
5af094b
to
2358e3e
Compare
RalfJung
reviewed
Aug 10, 2019
|
Looking good, thanks a lot! Let's get this into the beta. @bors r+ p=1 |
|
📌 Commit 2358e3e has been approved by |
bors
added
S-waiting-on-bors
RalfJung
changed the title
|
☀️ Test successful - checks-azure |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 17, 2020
implement zeroed and uninitialized with MaybeUninit This is the second attempt of doing such a change (first PR: rust-lang#62150). The last change [got reverted](rust-lang#63343) because it [caused](rust-lang#62825) some [issues](rust-lang#52898 (comment)) in [code that incorrectly used these functions](AltF02/x11-rs#99). Since then, the [problematic code has been fixed](AltF02/x11-rs#101), and rustc [gained a lint](rust-lang#63346) that is able to detect many misuses of these functions statically and a [dynamic check that panics](rust-lang#66059) instead of causing UB for some incorrect uses. Fixes rust-lang#62825
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 17, 2020
implement zeroed and uninitialized with MaybeUninit This is the second attempt of doing such a change (first PR: rust-lang#62150). The last change [got reverted](rust-lang#63343) because it [caused](rust-lang#62825) some [issues](rust-lang#52898 (comment)) in [code that incorrectly used these functions](AltF02/x11-rs#99). Since then, the [problematic code has been fixed](AltF02/x11-rs#101), and rustc [gained a lint](rust-lang#63346) that is able to detect many misuses of these functions statically and a [dynamic check that panics](rust-lang#66059) instead of causing UB for some incorrect uses. Fixes rust-lang#62825
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 17, 2020
implement zeroed and uninitialized with MaybeUninit This is the second attempt of doing such a change (first PR: rust-lang#62150). The last change [got reverted](rust-lang#63343) because it [caused](rust-lang#62825) some [issues](rust-lang#52898 (comment)) in [code that incorrectly used these functions](AltF02/x11-rs#99). Since then, the [problematic code has been fixed](AltF02/x11-rs#101), and rustc [gained a lint](rust-lang#63346) that is able to detect many misuses of these functions statically and a [dynamic check that panics](rust-lang#66059) instead of causing UB for some incorrect uses. Fixes rust-lang#62825
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #62825
cc @RalfJung