-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #63517
Rollup of 10 pull requests #63517
Commits on Jul 30, 2019
-
Deduplicate some error messages
chansuke committedJul 30, 2019 Configuration menu - View commit details
-
Copy full SHA for a1df132 - Browse repository at this point
Copy the full SHA a1df132View commit details
Commits on Aug 8, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 43a2cbd - Browse repository at this point
Copy the full SHA 43a2cbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for a694782 - Browse repository at this point
Copy the full SHA a694782View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9294a2 - Browse repository at this point
Copy the full SHA d9294a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f395787 - Browse repository at this point
Copy the full SHA f395787View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ce8f7a - Browse repository at this point
Copy the full SHA 5ce8f7aView commit details
Commits on Aug 9, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 2644205 - Browse repository at this point
Copy the full SHA 2644205View commit details
Commits on Aug 10, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 51ce121 - Browse repository at this point
Copy the full SHA 51ce121View commit details
Commits on Aug 12, 2019
-
Configuration menu - View commit details
-
Copy full SHA for fa7a40c - Browse repository at this point
Copy the full SHA fa7a40cView commit details -
ci: move mirrors to their standalone bucket
Currently mirrors are stored in the rust-lang-ci2 S3 bucket along with CI toolchains. This is problematic for multiple reasons: - CI IAM credentials are allowed to both edit and delete those files. A malicious user gaining access to those credentials would be able to change our mirrored dependencies, possibly backdooring the compiler. - Contents of the rust-lang-ci2 bucket are disposable except for the mirrors' content. When we implement backups for S3 buckets we'd have to replicate just that part of the bucket, complicating the backup logic and increasing the chance of mistakes. A standalone bucket will be way easier to backup. This commit switches our CI to use the new rust-lang-ci-mirrors bucket.
Configuration menu - View commit details
-
Copy full SHA for eb832b2 - Browse repository at this point
Copy the full SHA eb832b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91af5c2 - Browse repository at this point
Copy the full SHA 91af5c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for fecf305 - Browse repository at this point
Copy the full SHA fecf305View commit details -
Apply suggestions from code review
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e30480c - Browse repository at this point
Copy the full SHA e30480cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 34dcca2 - Browse repository at this point
Copy the full SHA 34dcca2View commit details -
typeck: Prohibit RPIT types that inherit lifetimes
This commit prohibits return position `impl Trait` types that "inherit lifetimes" from the parent scope. The intent is to forbid cases that are challenging until they can be addressed properly.
Configuration menu - View commit details
-
Copy full SHA for 861d1bb - Browse repository at this point
Copy the full SHA 861d1bbView commit details
Commits on Aug 13, 2019
-
Rollup merge of rust-lang#62760 - chansuke:dedupe-error-messages, r=z…
…ackmdavis Deduplicate error messages in `librsctc_mir` Deduplicated the error messages in `librustc_mir`. rust-lang#62022
Configuration menu - View commit details
-
Copy full SHA for 9365d44 - Browse repository at this point
Copy the full SHA 9365d44View commit details -
Rollup merge of rust-lang#62849 - davidtwco:prohibit-inheriting-lifet…
…imes, r=nikomatsakis typeck: Prohibit RPIT types that inherit lifetimes Part of rust-lang#61949. This PR prohibits return position `impl Trait` types that "inherit lifetimes" from the parent scope. The intent is to forbid cases that are challenging until they can be addressed properly. cc @nikomatsakis
Configuration menu - View commit details
-
Copy full SHA for 95d7635 - Browse repository at this point
Copy the full SHA 95d7635View commit details -
Rollup merge of rust-lang#63383 - Centril:async-lifetime-elision-test…
…s, r=nikomatsakis `async fn` lifetime elision tests Add `async fn` version of the tests in rust-lang#61207 per the first checkbox in rust-lang#62121 (comment). Works towards resolving blockers in rust-lang#63209. r? @nikomatsakis cc @cramertj
Configuration menu - View commit details
-
Copy full SHA for 85662a5 - Browse repository at this point
Copy the full SHA 85662a5View commit details -
Rollup merge of rust-lang#63421 - clarfon:escape_default, r=dtolnay
Implement Clone, Display for ascii::EscapeDefault This will mimic the same behaviour as the `char` version; `Display`ing the iterator will give its string representation without advancing it.
Configuration menu - View commit details
-
Copy full SHA for 1b26851 - Browse repository at this point
Copy the full SHA 1b26851View commit details -
Rollup merge of rust-lang#63459 - eddyb:issue-63430, r=petrochenkov
syntax: account for CVarArgs being in the argument list. Fixes rust-lang#63430 by testing for `1` argument (the `CVarArgs` itself) instead of `0`. Note that the error has basically been impossible to trigger since the change that caused rust-lang#63430, so perhaps we need an audit of untested errors. Also, this check probably belongs in AST validation/HIR lowering, but I'd rather fix it in place for now. r? @petrochenkov cc @dlrobertson
Configuration menu - View commit details
-
Copy full SHA for 466312c - Browse repository at this point
Copy the full SHA 466312cView commit details -
Rollup merge of rust-lang#63475 - iluuu1994:issue-62632, r=Centril
Bring back suggestion for splitting `<-` into `< -` Closes rust-lang#62632
Configuration menu - View commit details
-
Copy full SHA for 87ec7b4 - Browse repository at this point
Copy the full SHA 87ec7b4View commit details -
Rollup merge of rust-lang#63485 - pietroalbini:new-mirror-bucket, r=a…
…lexcrichton ci: move mirrors to their standalone bucket Currently mirrors are stored in the rust-lang-ci2 S3 bucket along with CI toolchains. This is problematic for multiple reasons: - CI IAM credentials are allowed to both edit and delete those files. A malicious user gaining access to those credentials would be able to change our mirrored dependencies, possibly compromising the compiler. - Contents of the rust-lang-ci2 bucket are disposable except for the mirrors' content. When we implement backups for S3 buckets we'd have to replicate just that part of the bucket, complicating the backup logic and increasing the chance of mistakes. A standalone bucket will be way easier to backup. This commit switches our CI to use the new rust-lang-ci-mirrors bucket. r? @alexcrichton
Configuration menu - View commit details
-
Copy full SHA for 640548c - Browse repository at this point
Copy the full SHA 640548cView commit details -
Rollup merge of rust-lang#63486 - Observer42:document-from-trait-in-b…
…inaryheap, r=Centril Document `From` trait for `BinaryHeap` This PR solves part of rust-lang#51430. (cc @skade) The comments described allocation and time complexity of the conversion from Vec to BinaryHeap The complexity description of BinaryHeap operations is available at mod level: https://doc.rust-lang.org/alloc/collections/binary_heap/index.html But it doesn't show up at BinaryHeap page: https://doc.rust-lang.org/alloc/collections/binary_heap/struct.BinaryHeap.html
Configuration menu - View commit details
-
Copy full SHA for 716a818 - Browse repository at this point
Copy the full SHA 716a818View commit details -
Rollup merge of rust-lang#63488 - RalfJung:diagnostic-docs, r=zackmdavis
Configuration menu - View commit details
-
Copy full SHA for e3115be - Browse repository at this point
Copy the full SHA e3115beView commit details -
Rollup merge of rust-lang#63493 - sd234678:remove-unneeded-comment-fr…
…om-src/libcore/hash, r=Centril Remove unneeded comment in src/libcore/hash/mod.rs Split out from larger PR rust-lang#63347 - other sections in there require further discussion. r? @Centril
Configuration menu - View commit details
-
Copy full SHA for f1651d8 - Browse repository at this point
Copy the full SHA f1651d8View commit details