-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 16 pull requests #63541
Rollup of 16 pull requests #63541
Commits on Jul 30, 2019
-
Deduplicate some error messages
chansuke committedJul 30, 2019 Configuration menu - View commit details
-
Copy full SHA for a1df132 - Browse repository at this point
Copy the full SHA a1df132View commit details
Commits on Aug 8, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 43a2cbd - Browse repository at this point
Copy the full SHA 43a2cbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for a694782 - Browse repository at this point
Copy the full SHA a694782View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9294a2 - Browse repository at this point
Copy the full SHA d9294a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f395787 - Browse repository at this point
Copy the full SHA f395787View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ce8f7a - Browse repository at this point
Copy the full SHA 5ce8f7aView commit details
Commits on Aug 9, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 2644205 - Browse repository at this point
Copy the full SHA 2644205View commit details
Commits on Aug 10, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 51ce121 - Browse repository at this point
Copy the full SHA 51ce121View commit details
Commits on Aug 12, 2019
-
Configuration menu - View commit details
-
Copy full SHA for fa7a40c - Browse repository at this point
Copy the full SHA fa7a40cView commit details -
ci: move mirrors to their standalone bucket
Currently mirrors are stored in the rust-lang-ci2 S3 bucket along with CI toolchains. This is problematic for multiple reasons: - CI IAM credentials are allowed to both edit and delete those files. A malicious user gaining access to those credentials would be able to change our mirrored dependencies, possibly backdooring the compiler. - Contents of the rust-lang-ci2 bucket are disposable except for the mirrors' content. When we implement backups for S3 buckets we'd have to replicate just that part of the bucket, complicating the backup logic and increasing the chance of mistakes. A standalone bucket will be way easier to backup. This commit switches our CI to use the new rust-lang-ci-mirrors bucket.
Configuration menu - View commit details
-
Copy full SHA for eb832b2 - Browse repository at this point
Copy the full SHA eb832b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91af5c2 - Browse repository at this point
Copy the full SHA 91af5c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for fecf305 - Browse repository at this point
Copy the full SHA fecf305View commit details -
Apply suggestions from code review
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e30480c - Browse repository at this point
Copy the full SHA e30480cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 34dcca2 - Browse repository at this point
Copy the full SHA 34dcca2View commit details -
typeck: Prohibit RPIT types that inherit lifetimes
This commit prohibits return position `impl Trait` types that "inherit lifetimes" from the parent scope. The intent is to forbid cases that are challenging until they can be addressed properly.
Configuration menu - View commit details
-
Copy full SHA for 861d1bb - Browse repository at this point
Copy the full SHA 861d1bbView commit details -
use
ParamName
to track in-scope lifetimes instead of IdentThis allows us to record "fresh" lifetime names for cases like `impl Foo<'_>`.
Configuration menu - View commit details
-
Copy full SHA for 18e5453 - Browse repository at this point
Copy the full SHA 18e5453View commit details -
revamp how we handle elision in async fn
We now always make fresh lifetimne parameters for all elided lifetimes, whether they are in the inputs or outputs. But then we generate `'_` in the case of elided lifetimes from the outputs. Example: ```rust async fn foo<'a>(x: &'a u32) -> &u32 { .. } ``` becomes ```rust type Foo<'a, 'b> = impl Future<Output = &'b u32>; fn foo<'a>(x: &'a u32) -> Foo<'a, '_> ```
Configuration menu - View commit details
-
Copy full SHA for 03e7b96 - Browse repository at this point
Copy the full SHA 03e7b96View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbe8518 - Browse repository at this point
Copy the full SHA cbe8518View commit details -
Configuration menu - View commit details
-
Copy full SHA for a02a171 - Browse repository at this point
Copy the full SHA a02a171View commit details -
Configuration menu - View commit details
-
Copy full SHA for 948739f - Browse repository at this point
Copy the full SHA 948739fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad214fe - Browse repository at this point
Copy the full SHA ad214feView commit details
Commits on Aug 13, 2019
-
clear in-scope lifetimes for nested items in HIR lowering
This was causing us to incorrectly think the lifetimes were already declared on the scope for the nested item, when in fact they are not inherited.
Configuration menu - View commit details
-
Copy full SHA for e4756e6 - Browse repository at this point
Copy the full SHA e4756e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7c7c52 - Browse repository at this point
Copy the full SHA d7c7c52View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84cab92 - Browse repository at this point
Copy the full SHA 84cab92View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9b3a01 - Browse repository at this point
Copy the full SHA e9b3a01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18d69c8 - Browse repository at this point
Copy the full SHA 18d69c8View commit details -
RELEASES.md: ? is one of three Kleene operators
The slash and quotes in ?/“Kleene” appeared to define “Kleene” as the name for the ? operator, which is not the case. Rust has three Kleene operators *, +, ?. (Pointed out by /u/Sharlinator on Reddit.) Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Configuration menu - View commit details
-
Copy full SHA for c259d1c - Browse repository at this point
Copy the full SHA c259d1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea1a9a0 - Browse repository at this point
Copy the full SHA ea1a9a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8abaf9d - Browse repository at this point
Copy the full SHA 8abaf9dView commit details -
Disable --cfg bootstrap in libcore
This is needed to permit us building core_arch which is a submodule dep (so we can't snap it to the new beta compiler).
Configuration menu - View commit details
-
Copy full SHA for 5b21f31 - Browse repository at this point
Copy the full SHA 5b21f31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28d2279 - Browse repository at this point
Copy the full SHA 28d2279View commit details -
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 643ddfa - Browse repository at this point
Copy the full SHA 643ddfaView commit details
Commits on Aug 14, 2019
-
Rollup merge of rust-lang#62760 - chansuke:dedupe-error-messages, r=z…
…ackmdavis Deduplicate error messages in `librsctc_mir` Deduplicated the error messages in `librustc_mir`. rust-lang#62022
Configuration menu - View commit details
-
Copy full SHA for 0bc14fc - Browse repository at this point
Copy the full SHA 0bc14fcView commit details -
Rollup merge of rust-lang#62849 - davidtwco:prohibit-inheriting-lifet…
…imes, r=nikomatsakis typeck: Prohibit RPIT types that inherit lifetimes Part of rust-lang#61949. This PR prohibits return position `impl Trait` types that "inherit lifetimes" from the parent scope. The intent is to forbid cases that are challenging until they can be addressed properly. cc @nikomatsakis
Configuration menu - View commit details
-
Copy full SHA for d831f02 - Browse repository at this point
Copy the full SHA d831f02View commit details -
Rollup merge of rust-lang#63383 - Centril:async-lifetime-elision-test…
…s, r=nikomatsakis `async fn` lifetime elision tests Add `async fn` version of the tests in rust-lang#61207 per the first checkbox in rust-lang#62121 (comment). Works towards resolving blockers in rust-lang#63209. r? @nikomatsakis cc @cramertj
Configuration menu - View commit details
-
Copy full SHA for ab4c257 - Browse repository at this point
Copy the full SHA ab4c257View commit details -
Rollup merge of rust-lang#63421 - clarfon:escape_default, r=dtolnay
Implement Clone, Display for ascii::EscapeDefault This will mimic the same behaviour as the `char` version; `Display`ing the iterator will give its string representation without advancing it.
Configuration menu - View commit details
-
Copy full SHA for f16924a - Browse repository at this point
Copy the full SHA f16924aView commit details -
Rollup merge of rust-lang#63459 - eddyb:issue-63430, r=petrochenkov
syntax: account for CVarArgs being in the argument list. Fixes rust-lang#63430 by testing for `1` argument (the `CVarArgs` itself) instead of `0`. Note that the error has basically been impossible to trigger since the change that caused rust-lang#63430, so perhaps we need an audit of untested errors. Also, this check probably belongs in AST validation/HIR lowering, but I'd rather fix it in place for now. r? @petrochenkov cc @dlrobertson
Configuration menu - View commit details
-
Copy full SHA for ef73a9b - Browse repository at this point
Copy the full SHA ef73a9bView commit details -
Rollup merge of rust-lang#63475 - iluuu1994:issue-62632, r=Centril
Bring back suggestion for splitting `<-` into `< -` Closes rust-lang#62632
Configuration menu - View commit details
-
Copy full SHA for 69848fe - Browse repository at this point
Copy the full SHA 69848feView commit details -
Rollup merge of rust-lang#63485 - pietroalbini:new-mirror-bucket, r=a…
…lexcrichton ci: move mirrors to their standalone bucket Currently mirrors are stored in the rust-lang-ci2 S3 bucket along with CI toolchains. This is problematic for multiple reasons: - CI IAM credentials are allowed to both edit and delete those files. A malicious user gaining access to those credentials would be able to change our mirrored dependencies, possibly compromising the compiler. - Contents of the rust-lang-ci2 bucket are disposable except for the mirrors' content. When we implement backups for S3 buckets we'd have to replicate just that part of the bucket, complicating the backup logic and increasing the chance of mistakes. A standalone bucket will be way easier to backup. This commit switches our CI to use the new rust-lang-ci-mirrors bucket. r? @alexcrichton
Configuration menu - View commit details
-
Copy full SHA for 159b595 - Browse repository at this point
Copy the full SHA 159b595View commit details -
Rollup merge of rust-lang#63486 - Observer42:document-from-trait-in-b…
…inaryheap, r=Centril Document `From` trait for `BinaryHeap` This PR solves part of rust-lang#51430. (cc @skade) The comments described allocation and time complexity of the conversion from Vec to BinaryHeap The complexity description of BinaryHeap operations is available at mod level: https://doc.rust-lang.org/alloc/collections/binary_heap/index.html But it doesn't show up at BinaryHeap page: https://doc.rust-lang.org/alloc/collections/binary_heap/struct.BinaryHeap.html
Configuration menu - View commit details
-
Copy full SHA for ffeb3e0 - Browse repository at this point
Copy the full SHA ffeb3e0View commit details -
Rollup merge of rust-lang#63488 - RalfJung:diagnostic-docs, r=zackmdavis
Configuration menu - View commit details
-
Copy full SHA for 69c16b9 - Browse repository at this point
Copy the full SHA 69c16b9View commit details -
Rollup merge of rust-lang#63493 - sd234678:remove-unneeded-comment-fr…
…om-src/libcore/hash, r=Centril Remove unneeded comment in src/libcore/hash/mod.rs Split out from larger PR rust-lang#63347 - other sections in there require further discussion. r? @Centril
Configuration menu - View commit details
-
Copy full SHA for f6d73dd - Browse repository at this point
Copy the full SHA f6d73ddView commit details -
Rollup merge of rust-lang#63499 - nikomatsakis:issuee-63388-async-fn-…
…elision-self-mut-self, r=cramertj handle elision in async fn correctly We now always make fresh lifetimne parameters for all elided lifetimes, whether they are in the inputs or outputs. But then we generate `'_` in the case of elided lifetimes from the outputs. Example: ```rust async fn foo<'a>(x: &'a u32) -> &u32 { .. } ``` becomes ```rust type Foo<'a, 'b> = impl Future<Output = &'b u32>; fn foo<'a>(x: &'a u32) -> Foo<'a, '_> ``` Fixes rust-lang#63388
Configuration menu - View commit details
-
Copy full SHA for 8243535 - Browse repository at this point
Copy the full SHA 8243535View commit details -
Rollup merge of rust-lang#63501 - nikomatsakis:issue-63500-async-anon…
…-impl-lifetime, r=cramertj use `ParamName` to track in-scope lifetimes instead of Ident Also, clear in-scope lifetimes when visiting nested items. Fixes rust-lang#63500. Fixes rust-lang#63225. Fixes rust-lang#52532. r? @cramertj
Configuration menu - View commit details
-
Copy full SHA for 6651373 - Browse repository at this point
Copy the full SHA 6651373View commit details -
Rollup merge of rust-lang#63512 - 95th:master, r=cramertj
Provide map_ok and map_err method for Poll<Option<Result<T, E>>> Currently `map_ok` and `map_err` methods are given for `Poll<Result<T, E>>`. This PR adds these methods for `Poll<Option<Result<T, E>>>` as they are helpful in stream building code.
Configuration menu - View commit details
-
Copy full SHA for d01acf7 - Browse repository at this point
Copy the full SHA d01acf7View commit details -
Rollup merge of rust-lang#63529 - andersk:release-notes-kleene, r=Cen…
…tril RELEASES.md: ? is one of three Kleene operators The slash and quotes in ?/“Kleene” appeared to define “Kleene” as the name for the `?` operator, which is not the case. Rust has three Kleene operators `*`, `+`, `?`. ([Pointed out](https://www.reddit.com/r/rust/comments/cprt0z/rust_1370_prerelease_testing/ewr90y3/) by /u/Sharlinator on Reddit.)
Configuration menu - View commit details
-
Copy full SHA for 5823213 - Browse repository at this point
Copy the full SHA 5823213View commit details -
Rollup merge of rust-lang#63530 - ehuss:typo-statemement, r=centril
Fix typo in error message.
Configuration menu - View commit details
-
Copy full SHA for cd20a2e - Browse repository at this point
Copy the full SHA cd20a2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f5b0572 - Browse repository at this point
Copy the full SHA f5b0572View commit details